Thread: Login Dialog not working

The part of three failed attempts is not working. Please help with this. Thank you!

Private Sub cmd_ok_Click()

Dim attempt As Integer
Dim valid As Boolean

attempt = 0
valid = False

Do
    attempt = attempt + 1
    If Me.cbo_User.Column(2) = Me.txt_Password Then
        valid = True
        MsgBox "Password accepted"
        DoCmd.OpenForm "Student", acNormal
        DoCmd.Close acForm, "Login"
    Else
        valid = False
         MsgBox "Wrong password entered." & _
        vbCrLf & "Please re-enter password.", _
        vbExclamation, "Invalid Password"
        Me.txt_Password.SetFocus 'places the cursor in password control
        Exit Sub
    End If
    
Loop Until (valid = True) Or (attempt >= 3)

If attempt >= 3 Then
    MsgBox "You do not have access to this database. Please contact your system administrator.", vbCritical, "Restricted Access!"
    Exit Sub
End If
    

End Sub

The problem is that after the 3rd attempt, the message box" "You do not have access to this database. Please contact your system administrator." does not come up.

I'm going to agree with OnError. Exit sub in your else block is causing you to exit and when you come back into the sub, so your attempt variable is reset to 0. Which kind of makes me think that you need to declare the attempt variable as static. You would also need to initialize that variable on the form load event to 0.

My suggestion,

Static attempt as integer
Dim valid as Boolean

If attempt >= 3 Then
     'messagebox and events for no access
     cmd_ok.enabled = false 'This will cause them to have to reopen the form to submit again.
else
     'check the password
     if password = me.txtPassword Then
          valid = true
     else
          me.txtPassword.value = ""
          'messagebox and events for this
          attempt = attempt + 1
    End If
End If

I'm really leaning at you have a variable scope issue. Each time the user clicks go, the attempts are reset to 0. With static, the number should be saved until the form is closed and is re-initialized.

I was assuming that the user was clicking the button again to enter the password that would re-fire the event. Just setting the focus to the textbox wont do anything but point the user to the wrong input. They still have to resubmit the new information somehow. Having it inside a loop esentially doesn't do anything. I can only assume that without exit sub it would hit the 3 attempts quickly because there isn't anything stopping execution when the event fires, while the user enters new data. Unless .setFocus does something I am not aware of for validation. If .setFocus does halt execution then yes. Getting rid of exit sub will work.

To fix the attempts you could reset the static variable to =0 after a sucessful login then you always start fresh after a good login.