Loop not looping

**bg_ac_dziner** · 03-16-2010, 02:06 PM

I am a newby to VBA and below I am trying to generate a random number between 3000 and 3777, but it doesn't work. It only goes through once then quits producing all kinds of numbers outside the desired range. Here is my code:

Option Explicit

Sub Enter_Click()

Dim BCN As Integer
Dim BCN1 As Integer
Dim BCN2 As Integer

Do
Range("D6") = Rnd() * 10000
Loop Until Range("D6").Value >= 3000 <= 3700
BCN = ActiveSheet.Range("D6").Value
ActiveSheet.Shapes("BCN1").Select
Selection.Characters.Text = BCN
ActiveSheet.Shapes("BCN2").Select
Selection.Characters.Text = BCN

' the above code is supposed to loop until a random number between
' 3000 and 3777 is produced, but it doesn't work. It only goes
' through once as if the do loop isn't even there, then quits.

End Sub

What am I doing wrong??

**ChemistB** · 03-16-2010, 02:53 PM

Your Loop Until line isn't correct

Loop Until Range("D6").Value >= 3000 And Range("D6") <= 3700

You could try the RANDBETWEEN Function instead and skip the Do loop

Range("D6") = WorksheetFunction.RandBetween(3000, 3700)

Lastly, if you're expecting Shapes("BCN1") to convert to Shapes(32141) (or somesuch), it won't because the BCN is inside quotation marks and won't be seen as a variable. Hope that helped.