Simplify numerous conditional statements

If it works, it's good. The code logic could be simplified by redesigning your input, say, by disabling controls when certain entries are made, or limiting the values allowed. But that would require other code. Or you could simplify it when all you are checking is that the angle(?) values are less than 90 or blank, like this, though this may miss other requirements:

If (.TextBox6.Value <= 90 Or .TextBox6.Value = "") And _
(.TextBox7.Value <= 90 Or .TextBox7.Value = "") And _
(.TextBox8.Value <= 90 Or .TextBox8.Value = "") And _
(.TextBox9.Value <= 90 Or .TextBox9.Value = "") And _
(.TextBox12.Value <= 90 Or .TextBox12.Value = "") Then
Call sb_tube_less_equal_90
GoTo Drawing
Exit Sub
Else
GoTo Errmessage
Exit Sub
End If

Originally Posted by Bernie Deitrick

If it works, it's good. The code logic could be simplified by redesigning your input, say, by disabling controls when certain entries are made, or limiting the values allowed. But that would require other code. Or you could simplify it when all you are checking is that the angle(?) values are less than 90 or blank, like this, though this may miss other requirements:

If (.TextBox6.Value <= 90 Or .TextBox6.Value = "") And _
(.TextBox7.Value <= 90 Or .TextBox7.Value = "") And _
(.TextBox8.Value <= 90 Or .TextBox8.Value = "") And _
(.TextBox9.Value <= 90 Or .TextBox9.Value = "") And _
(.TextBox12.Value <= 90 Or .TextBox12.Value = "") Then
Call sb_tube_less_equal_90
GoTo Drawing
Exit Sub
Else
GoTo Errmessage
Exit Sub
End If

Your suggestion of disabling the remaining controls if some controls do not meet criteria seems logical and will definitely consider that approach, thank you for that. Your AND-OR combination might do the trick but still has the length issues I am trying to resolve.

Yes, the code is working and does its purpose, but my OC side of me is itching and wants to know if there are other ways to simplify it. Plus, I do not want other coders who will work on it to get lost in the process should they need to make some adjustment, in case I am not around to do it.

Originally Posted by ykobure

Plus, I do not want other coders who will work on it to get lost in the process should they need to make some adjustment, in case I am not around to do it.

I'd suggest you start by giving your controls more meaningful names then - currently anyone new will have to keep referring to the form to remind themselves what each control actually is.