Thread: Recorded macro doesn't seem to provide expected result

hi Andy,

I think I got it. There was a formula on a column that changed my expected result. A bit stupid I didn't notice really.

I usually do my best cleaning them. I am curious how one would grade my code;

Code:

Sub test()


    Dim Eurocode As String
    Dim Stickers As String
    Dim Verpakken As String
    Dim Eenheid As Integer
       
   ' Ask for Eurocode
   Eurocode = InputBox("Geef een Eurocode in en klik op OK", "Invoer vereist")
   
   
annuleer:
   ' Provide the option to cancel
   If StrPtr(Eurocode) = 0 Then
   MsgBox "U heeft de invoer onderbroken. Er zijn geen gegevens toegevoegd", vbExclamation, "Waarschuwing"
   Exit Sub
   End If
   
   ' Keep asking for input if someone clicked OK but didn't fill anything in
   Do While Len(Eurocode) = 0
   Eurocode = InputBox("U heeft niets ingetypt. Typ een Eurocode in of klik op annuleren ", "Invoer vereist")
     ' cancelling still has to be possible
     If StrPtr(Eurocode) = 0 Then GoTo annuleer
   Loop
   

   
   ' asking a few questions
   Stickers = MsgBox("Moeten er stickers gemaakt worden?", vbQuestion + vbYesNo, "Keuze vereist")
   If (Stickers = vbNo) Then
   Stickers = "NEE"
   Else
   Stickers = "JA"
   End If
   
   Verpakken = MsgBox("Moet er verpakt worden?", vbQuestion + vbYesNo, "Keuze vereist")
   If (Verpakken = vbNo) Then
   Verpakken = "NEE"
   Else
   Verpakken = "JA"
   End If

    ' fetch the last row.
    LastRow = Range("A" & Rows.Count).End(xlUp).Row
    
    ' doesn't work yet.
    Cells(1, 1).Value = Jeroen
  
    
    LastRow = Range("A" & Rows.Count).End(xlUp).Row
   ' sorting thingy
    Columns("A:A").Select
    ActiveWorkbook.Worksheets("Artikelen").Sort.SortFields.Clear
    ActiveWorkbook.Worksheets("Artikelen").Sort.SortFields.Add Key:=Range("A1"), _
        SortOn:=xlSortOnValues, Order:=xlAscending, DataOption:=xlSortNormal
    With ActiveWorkbook.Worksheets("Artikelen").Sort
        .SetRange Range("A2:E" & LastRow)
        .Header = xlNo
        .MatchCase = False
        .Orientation = xlTopToBottom
        .SortMethod = xlPinYin
        .Apply
    End With
End Sub