Userform Commandbutton does not update on click

Greetings,

I expanded on the code provided here by replacing the "Do...Loop Until" section with a userform. The revised code is Sub UpdateSector.

When Sub UpdateSector is called, it works fine, ie, displays the userform when input is required; updates the combobox selection / input to the relevant field when the commandbutton is clicked; then closes the userform.

However if I add any code after the For-Next statement, say eg Msgbox "Test", the combobox selection/ input is updated to the relevant field only after the Msgbox "Test" is displayed.

Can anyone please help me identify the reason for this behaviour? Below is the entire code (Please bear with me as I do not know which line could be causing the problem) in the standard module

Please Login or Register  to view this content.

and code in the userform module

Please Login or Register  to view this content.

Let me know if I need to attach a sample file. Many many thanks
Asha

A sample file I suspect would help, but as two general comments:
1. Avoid public variables. They are often unnecessary, as here.
2. Don't use the RowSource property (unless you absolutely have to use the column headers). Assign the value of the range you want to the List property of the Combobox.

In order:
1. When using forms, you can set up property procedures so that your code can read the values from the form - this does require you to keep the form hidden rather than unloaded.
2. If you bind a control to the worksheet, you can find that changes on the sheet trigger events on your form that you weren't expecting or wanting. Since you have no need of a link between the two, there is no benefit to using Rowsource.

As far as your code goes, it is working in exactly the right order, it's just that you have turned off screenupdating so you see the message box appear first, but the data is actually already present in the sheet.