UserForm Validation - Check Text and Combo Boxes have entries before saving.

[Barny505]

Hello All,

Im a noob when it comes to VBA userforms and I'm going around in circles with this problem. I have put together this code that checks if a .Tag caption has "MUST" in it then checks to see if the text or combo boxes have entries in and if the don't a MsgBox pops up and says you have missed X please fill it out. It kind of works as it does check the text and comboBoxs but in a random order (Middle - Top - Bottom ) - so my question is... is there a way to get it to check from the 1st box on the form and then step through them in order?

The workbook, userform and code are attached. code below.

Thanks in advance.

Private Sub SaveButton_Click()
'Writing to the databases

'After you have entered details in to the form this writes to the database

Dim emptyRow As Long
  Dim cCont As Control
  
     'FILL ALL MANDATORY CONTROLS TAG  PROPERTIES WITH "MUST"
    For Each cCont In Me.Controls
        If UCase(cCont.Tag) = "MUST" Then
            If cCont = vbNullString Then
                MsgBox "Missing Data in " & cCont.Name
                cCont.SetFocus
                Exit Sub
              End If
        End If
    Next cCont
       
    
'Make Sheet active
Sheet8.Activate

'Determine emptyRow
emptyRow = WorksheetFunction.CountA(Range("A:A")) + 1

'Transfer information
Cells(emptyRow, 1).Value = YearComboBox.Value
Cells(emptyRow, 2).Value = CompanyComboBox.Value
Cells(emptyRow, 3).Value = SiteComboBox.Value
Cells(emptyRow, 4).Value = TestTypeL1ComboBox.Value
Cells(emptyRow, 5).Value = TestTypeL2ComboBox.Value
Cells(emptyRow, 6).Value = TestTypeL3ComboBox.Value
Cells(emptyRow, 7).Value = TotSamplesTextBox.Value
Cells(emptyRow, 8).Value = Results1TextBox.Value
Cells(emptyRow, 9).Value = Results2TextBox.Value
Cells(emptyRow, 10).Value = Results3TextBox.Value
    
End Sub

[Kyle123]

Welcome to the forum! When you joined recently you agreed to abide by the Forum Rules, but in haste I fear you might not have actually read them. Please stop and take a moment to read them now. We all follow these rules for the benefit of all, as must you. Thanks.

(link above in the menu bar)

Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code.

Posting code between [CODE] [/CODE] tags makes your code much easier to read and copy for testing, it also maintains VBA formatting.

Highlight your code and click the # icon at the top of your post window. More information about these and other tags can be found here

[Barny505]

Hi, Thanks for that - All sorted now I hope.