Userform and Module

Hi,

I have a userform and a module with macro button. Is this the right way to
call module from OK Button code ?

In my userform (Form name is MyForm), OK button has following code
Private Sub OKButton_Click()
....
....
InputA = Me.ComboBox1.Value
InputB = Me.ComboBox2.Value
Module1.MyTest
End Sub

In my module, I have
Option Explicit
Public InputA As String
Public InputB As String
sub MyTest()
....
....
MyForm.Show
....
some function here to compare with InputA and Input B
....
End Sub

If I run, the debug code will stop at "MyForm.Show".
What is wrong ?

Thanks.

Magix

Are you getting an error that it is already displayed, it looks as though
you have a loop to me, the macro shows the form, which calls the macro,
which shows the form ....

BTW I get an error with InputA

--
HTH

Bob Phillips

(remove nothere from email address if mailing direct)

"magix" <[email protected]> wrote in message
news:[email protected]...
> Hi,
>
> I have a userform and a module with macro button. Is this the right way to
> call module from OK Button code ?
>
> In my userform (Form name is MyForm), OK button has following code
> Private Sub OKButton_Click()
> ....
> ....
> InputA = Me.ComboBox1.Value
> InputB = Me.ComboBox2.Value
> Module1.MyTest
> End Sub
>
> In my module, I have
> Option Explicit
> Public InputA As String
> Public InputB As String
> sub MyTest()
> ....
> ....
> MyForm.Show
> ....
> some function here to compare with InputA and Input B
> ....
> End Sub
>
> If I run, the debug code will stop at "MyForm.Show".
> What is wrong ?
>
> Thanks.
>
> Magix
>
>

what would be the appropriate way then ? How to fix the code ?

"Bob Phillips" <[email protected]> wrote in message
news:[email protected]...
> Are you getting an error that it is already displayed, it looks as though
> you have a loop to me, the macro shows the form, which calls the macro,
> which shows the form ....
>
> BTW I get an error with InputA
>
> --
> HTH
>
> Bob Phillips
>
> (remove nothere from email address if mailing direct)
>
> "magix" <[email protected]> wrote in message
> news:[email protected]...
> > Hi,
> >
> > I have a userform and a module with macro button. Is this the right way
to
> > call module from OK Button code ?
> >
> > In my userform (Form name is MyForm), OK button has following code
> > Private Sub OKButton_Click()
> > ....
> > ....
> > InputA = Me.ComboBox1.Value
> > InputB = Me.ComboBox2.Value
> > Module1.MyTest
> > End Sub
> >
> > In my module, I have
> > Option Explicit
> > Public InputA As String
> > Public InputB As String
> > sub MyTest()
> > ....
> > ....
> > MyForm.Show
> > ....
> > some function here to compare with InputA and Input B
> > ....
> > End Sub
> >
> > If I run, the debug code will stop at "MyForm.Show".
> > What is wrong ?
> >
> > Thanks.
> >
> > Magix
> >
> >
>
>

I would need to know what you are trying to do, but you have to break that
loop.

--
HTH

Bob Phillips

(remove nothere from email address if mailing direct)

"magix" <[email protected]> wrote in message
news:[email protected]...
> what would be the appropriate way then ? How to fix the code ?
>
> "Bob Phillips" <[email protected]> wrote in message
> news:[email protected]...
> > Are you getting an error that it is already displayed, it looks as
though
> > you have a loop to me, the macro shows the form, which calls the macro,
> > which shows the form ....
> >
> > BTW I get an error with InputA
> >
> > --
> > HTH
> >
> > Bob Phillips
> >
> > (remove nothere from email address if mailing direct)
> >
> > "magix" <[email protected]> wrote in message
> > news:[email protected]...
> > > Hi,
> > >
> > > I have a userform and a module with macro button. Is this the right
way
> to
> > > call module from OK Button code ?
> > >
> > > In my userform (Form name is MyForm), OK button has following code
> > > Private Sub OKButton_Click()
> > > ....
> > > ....
> > > InputA = Me.ComboBox1.Value
> > > InputB = Me.ComboBox2.Value
> > > Module1.MyTest
> > > End Sub
> > >
> > > In my module, I have
> > > Option Explicit
> > > Public InputA As String
> > > Public InputB As String
> > > sub MyTest()
> > > ....
> > > ....
> > > MyForm.Show
> > > ....
> > > some function here to compare with InputA and Input B
> > > ....
> > > End Sub
> > >
> > > If I run, the debug code will stop at "MyForm.Show".
> > > What is wrong ?
> > >
> > > Thanks.
> > >
> > > Magix
> > >
> > >
> >
> >
>
>

very straight forward.
When click the macro button, it will launch the userform, then user selects
value from two combo boxes, let say:
InputA and InputB
then these two values will send to my module code, and do the remaining
tasks, as specified in module.

that's it. Which loop do you mean?

regards,
magix

"Bob Phillips" <[email protected]> wrote in message
news:[email protected]...
> I would need to know what you are trying to do, but you have to break that
> loop.
>
> --
> HTH
>
> Bob Phillips
>
> (remove nothere from email address if mailing direct)
>
> "magix" <[email protected]> wrote in message
> news:[email protected]...
> > what would be the appropriate way then ? How to fix the code ?
> >
> > "Bob Phillips" <[email protected]> wrote in message
> > news:[email protected]...
> > > Are you getting an error that it is already displayed, it looks as
> though
> > > you have a loop to me, the macro shows the form, which calls the
macro,
> > > which shows the form ....
> > >
> > > BTW I get an error with InputA
> > >
> > > --
> > > HTH
> > >
> > > Bob Phillips
> > >
> > > (remove nothere from email address if mailing direct)
> > >
> > > "magix" <[email protected]> wrote in message
> > > news:[email protected]...
> > > > Hi,
> > > >
> > > > I have a userform and a module with macro button. Is this the right
> way
> > to
> > > > call module from OK Button code ?
> > > >
> > > > In my userform (Form name is MyForm), OK button has following code
> > > > Private Sub OKButton_Click()
> > > > ....
> > > > ....
> > > > InputA = Me.ComboBox1.Value
> > > > InputB = Me.ComboBox2.Value
> > > > Module1.MyTest
> > > > End Sub
> > > >
> > > > In my module, I have
> > > > Option Explicit
> > > > Public InputA As String
> > > > Public InputB As String
> > > > sub MyTest()
> > > > ....
> > > > ....
> > > > MyForm.Show
> > > > ....
> > > > some function here to compare with InputA and Input B
> > > > ....
> > > > End Sub
> > > >
> > > > If I run, the debug code will stop at "MyForm.Show".
> > > > What is wrong ?
> > > >
> > > > Thanks.
> > > >
> > > > Magix
> > > >
> > > >
> > >
> > >
> >
> >
>
>

The loop whereby the macro shows the form, which calls the macro, which
shows the form ....

In my userform (Form name is MyForm), OK button has following code
Private Sub OKButton_Click()
....
....
InputA = Me.ComboBox1.Value
InputB = Me.ComboBox2.Value
End Sub

In my module, I have
Option Explicit
Public InputA As String
Public InputB As String
sub MyTest()
....
....
MyForm.Show
....
some function here to compare with InputA and Input B
....
End Sub

--
HTH

Bob Phillips

(remove nothere from email address if mailing direct)

"magix" <[email protected]> wrote in message
news:[email protected]...
> very straight forward.
> When click the macro button, it will launch the userform, then user
selects
> value from two combo boxes, let say:
> InputA and InputB
> then these two values will send to my module code, and do the remaining
> tasks, as specified in module.
>
> that's it. Which loop do you mean?
>
> regards,
> magix
>
> "Bob Phillips" <[email protected]> wrote in message
> news:[email protected]...
> > I would need to know what you are trying to do, but you have to break
that
> > loop.
> >
> > --
> > HTH
> >
> > Bob Phillips
> >
> > (remove nothere from email address if mailing direct)
> >
> > "magix" <[email protected]> wrote in message
> > news:[email protected]...
> > > what would be the appropriate way then ? How to fix the code ?
> > >
> > > "Bob Phillips" <[email protected]> wrote in message
> > > news:[email protected]...
> > > > Are you getting an error that it is already displayed, it looks as
> > though
> > > > you have a loop to me, the macro shows the form, which calls the
> macro,
> > > > which shows the form ....
> > > >
> > > > BTW I get an error with InputA
> > > >
> > > > --
> > > > HTH
> > > >
> > > > Bob Phillips
> > > >
> > > > (remove nothere from email address if mailing direct)
> > > >
> > > > "magix" <[email protected]> wrote in message
> > > > news:[email protected]...
> > > > > Hi,
> > > > >
> > > > > I have a userform and a module with macro button. Is this the
right
> > way
> > > to
> > > > > call module from OK Button code ?
> > > > >
> > > > > In my userform (Form name is MyForm), OK button has following code
> > > > > Private Sub OKButton_Click()
> > > > > ....
> > > > > ....
> > > > > InputA = Me.ComboBox1.Value
> > > > > InputB = Me.ComboBox2.Value
> > > > > Module1.MyTest
> > > > > End Sub
> > > > >
> > > > > In my module, I have
> > > > > Option Explicit
> > > > > Public InputA As String
> > > > > Public InputB As String
> > > > > sub MyTest()
> > > > > ....
> > > > > ....
> > > > > MyForm.Show
> > > > > ....
> > > > > some function here to compare with InputA and Input B
> > > > > ....
> > > > > End Sub
> > > > >
> > > > > If I run, the debug code will stop at "MyForm.Show".
> > > > > What is wrong ?
> > > > >
> > > > > Thanks.
> > > > >
> > > > > Magix
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> >
> >
>
>