64bit compatible code

writing code on 2013 64bit and expected to be able to use VB7 as follows

vba.png


but doesn't like it. am I doing something wrong?

(can't get uploaded image to display)

#If VBA7 Then
Private Declare PtrSafe Sub GetSystemTime Lib "kernel32" (ByRef lpSystemTime As SYSTEMTIME)
Private Declare PtrSafe Function GetTimeZoneInformation Lib "kernel32" (lpTimeZoneInformation As TIME_ZONE_INFORMATION) As LongPtr
#Else
Private Declare Sub GetSystemTime Lib "kernel32" (ByRef lpSystemTime As SYSTEMTIME)
Private Declare Function GetTimeZoneInformation Lib "kernel32" (lpTimeZoneInformation As TIME_ZONE_INFORMATION) As Long
#End If

That all looks correct to me.

Can you run the code?

For 64 bit not exists long statement. It's LongLong must be.
So, you also must add a check: is the 64-bit system?

Try this

Please Login or Register  to view this content.

Originally Posted by dalai

yes.

I've setup a simple macro and inserted the above pre-processor commands. The code is in red as above but I can compile and run the macro.

should I ignore this?

Yes. The code will appear in red but should still work.

FYI, GetTimeZoneInformation returns a Long, not a LongPtr even in 64 bit. There is no need for a #Win64 check here.

Originally Posted by The_Prist

For 64 bit not exists long statement. It's LongLong must be.
So, you also must add a check: is the 64-bit system?

Try this

Please Login or Register  to view this content.

thank you. I'm a bit confused now. so PtrSafe not required if Win64?

here my 32-bit declarations:

Private Declare Sub GetSystemTime Lib "kernel32" (ByRef lpSystemTime As SYSTEMTIME)
Private Declare Function GetTimeZoneInformation Lib "kernel32" (lpTimeZoneInformation As TIME_ZONE_INFORMATION) As Long
Public Declare Sub Sleep Lib "kernel32" (ByVal dwMilliseconds As Long)

is this ok?

'Util
#If VBA7 and Win64 Then
Private Declare PtrSafe Sub GetSystemTime Lib "kernel32" (ByRef lpSystemTime As SYSTEMTIME)
'GetTimeZoneInformation returns a Long, not a LongPtr even in 64 bit
Private Declare PtrSafe Function GetTimeZoneInformation Lib "kernel32" (lpTimeZoneInformation As TIME_ZONE_INFORMATION) As Long
#Else
Private Declare Sub GetSystemTime Lib "kernel32" (ByRef lpSystemTime As SYSTEMTIME)
Private Declare Function GetTimeZoneInformation Lib "kernel32" (lpTimeZoneInformation As TIME_ZONE_INFORMATION) As Long
#End If

'Main
#If VBA7 and Win64 Then
Public Declare PtrSafe Sub Sleep Lib "kernel32" (ByVal dwMilliseconds As Long)
#Else
Public Declare Sub Sleep Lib "kernel32" (ByVal dwMilliseconds As Long)
#End If

You only need to check Win64 in rare cases where an API function is 64bit specific - eg it returns a LongLong. For 99% of situations testing VBA7 is sufficient.

Looks OK to me.