Open multiple files and copy data is slow, code after end of loop not working - help?

Sorry, I have very little VBA skills...

I have a macro that is mostly working, but it is extremely slow and it stalls after completing the Do-While loop... I can't figure out why! Also, this macro calls another subroutine. On its own, the other subroutine is fast, but when it gets called it's very slow.

Any ideas?

Here is my code:

Sub Consolidate_To_One_Workbook()
Dim folderPath As String
Dim filename As String
Dim wb As Workbook

folderPath = "C:\Stuff\Macrofiles\" '

If Right(folderPath, 1) <> "\" Then folderPath = folderPath + "\"

Set OutputBook = Workbooks.Add
With OutputBook
.SaveAs filename:="C:\Stuff\Macrofiles\Output.xls"
End With

filename = Dir(folderPath & "*.xls")
Do While filename <> ""
Application.ScreenUpdating = False
Set wb = Workbooks.Open(folderPath & filename)

'Calls my subroutine here to operate on the just-opened workbook
Call DataGrabber

wb.Close False
filename = Dir
Loop

Application.ScreenUpdating = True

Workbooks("Output.xls").Worksheets("Sheet1").Activate
Columns("A:ZZ").EntireColumn.AutoFit

End Sub



Thanks in advance for your help!

Please Login or Register  to view this content.

Should be:

Please Login or Register  to view this content.

That may be your problem but:



Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code.

Posting code between [CODE]Please [url=https://www.excelforum.com/login.php]Login or Register [/url] to view this content.[/CODE] tags makes your code much easier to read and copy for testing, it also maintains VBA formatting.

Highlight your code and click the # icon at the top of your post window. More information about these and other tags can be found here