editing a spreadsheet using a userform

Your post does not comply with Rule 1 of our Forum RULES. Your post title should accurately and concisely describe your problem, not your anticipated solution.

Use terms appropriate to a Google search. Poor thread titles, like Please Help, Urgent, Need Help, Formula Problem, Code Problem, and Need Advice will be addressed according to the OP's experience in the forum: If you have less than 10 posts, expect (and respond to) a request to change your thread title. If you have 10 or more posts, expect your post to be locked, so you can start a new thread with an appropriate title.

To change a Title go to your first post, click EDIT then Go Advanced and change your title, if 2 days have passed ask a moderator to do it for you.

(This thread should receive no further responses until this moderation request is fulfilled, as per Forum Rule 7)

Here try this:

Sub EditAdd()

Dim emptyRow As Long
On Error Resume Next ' This command will skip error if it run into it
If Punchlist.TextBox1.Value <> "" Then
    flag = False
    i = 0
    id = Punchlist.TextBox1.Value
    emptyRow = WorksheetFunction.CountA(Range("A:A")) + 1 ' this fill find first empty row
    emptyRow = WorksheetFunction.Match(id, Sheets("Punchlist").Range("A1:A65536"), 0) 
        ' This will find matching value. If doesn't exist MATCH will produce error.
        ' That's why I put above On Error Resume Next to skip that error
        ' And since it's skiped a previous value will remain and data will be written in last row
        ' And if value does exist new emptyRow will be matching row

But you also need to use sheet where you writting data..

So instead of, for example:

Cells(emptyRow, j).Value

You should have:

Sheets("Punchlist").Cells(emptyRow, j).Value

or you need to declare it on start and use it like:

Dim wrksht as Worksheet
Set wrksht  = Sheets("Punchlist")


wrksht.Cells(emptyRow, j).Value

zbor,

Thanks for your help.

Im still getting an error.

Sub EditAdd()

Dim emptyRow As Long

If Punchlist.TextBox1.Value <> "" Then
flag = False
i = 0
id = Punchlist.TextBox1.Value
emptyRow = WorksheetFunction.CountA(Range("A:A")) + 1

Do While Cells(i + 1, 1).Value <> ""

If Cells(i + 1, 1).Value = id Then
flag = True
For j = 2 To 14
Cells(i + 1, j).Value = Punchlist.Controls("TextBox" & j).Value
Next j
End If

i = i + 1

Loop

If flag = False Then
For j = 1 To 14
Sheets("Punchlist").Cells(emptyRow, j).Value = Punchlist.Controls("textbox" & j).Value Next j
End If

End If

If Punchlist.TextBox1.Value <> "" Then
flag = False
i = 0
id = Punchlist.TextBox1.Value
emptyRow = WorksheetFunction.CountA(Range("A:A")) + 1

Do While Cells(i + 1, 1).Value <> ""

If Cells(i + 1, 1).Value = id Then
flag = True
For j = 2 To 14
Cells(i + 1, j).Value = Punchlist.Controls("textBox" & j).Value
Next j
End If

i = i + 1

Loop

If flag = False Then
For j = 1 To 14
Sheets("Punchlist").Cells(emptyRow, j).Value = Punchlist.Controls("textBox" & j).Value
Next j
End If

End If

End Sub

Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code.

Posting code between [CODE] [/CODE] tags makes your code much easier to read and copy for testing, it also maintains VBA formatting.

Highlight your code and click the # icon at the top of your post window. More information about these and other tags can be found here



(This thread should receive no further responses until this moderation request is fulfilled, as per Forum Rule 7)