Combining 2 String Variables

[ajw089]

Hello,

I'm putting together code that will attach a PDF to an email in Lotus Notes and send. However I'm having difficulty with the path of where the PDF is saved. I have two cells in Excel A1 which is the File Path and A2 which is the File name. Each of these are defined strings, SAVE_PATH and FILE_NAME.

Please Login or Register  to view this content.

When I test the code, it comes back as Attachment1 = "SAVE_PATHFILE_NAME" rather than "C:My Documents\Directory\Test_Analysis.pdf"

I have a feeling I'm missing something incredibly basic here, I just can't for the life of me figure it out.

[Pauleyb]

Range("SAVE_PATH") & Range("FILE_NAME")

[TMS]

Please Login or Register  to view this content.

Regards, TMS

[ajw089]

Hello, thank you for the replies! When I add the Range syntax I receive Run-time error '1004'; Method of 'Range' of object '_Global' failed. When I debug it shows that each of the variables SAVE_PATH and FILE_NAME are associated with the correct strings of data.

[TMS]

... associated with the correct strings of data.

And what are those strings of data?

[ajw089]

In debug, when I hover over SAVE_PATH it reflects "C:My Documents/Directory/" and when I hover over FILE_NAME it reflects "Test_Analysis.pdf". When these strings are typed together in:

Please Login or Register  to view this content.

The code is successful.

[TMS]

SAVE_PATH it reflects "C:My Documents/Directory/" and when I hover over FILE_NAME it reflects "Test_Analysis.pdf"

I think SAVE_PATH should be "C:\My Documents\Directory\"


Regards, TMS

[ajw089]

I fixed that oversight, however I'm still receiving the same Run-time error as before. I've mocked up an example with this code to highlight the error. I appreciate your assistance!

[TMS]

What version of Windows are you using? Normally, the My Documents folder is a sub-folder of the user directory. For example: C:\Users\Trevor\Documents

I'm not sure of the value of your "definer" functions. It would be easy for you, or anyone else to break the code by changing any of the text strings that you search for. And, really, it's unnecessary code. You would be far better off defining Named Ranges for all those references. You could hide the Named Ranges using VBA so only you know they exist an to what they refer. Less chance of them being corrupted unless the actual cell/row/column is deleted.

Regards, TMS

[ajw089]

Windows 7, the file path is fine because when I hard code the path in everything works well. I think I'm going to take your advice and rewrite the code to be based on Named Ranges. Thanks for your assistance!

[TMS]

This can't be right: "C:\My Documents\Directory\" .... unless you have created a separate My Documents folder in the C:\ drive

[ajw089]

I did create a separate My Documents folder in C for easier access rather than having to drill through multiple sub-folders. When I went back and created the named ranges as you suggested the code worked beautifully, thank you!

[TMS]

Fair enough!