Last Sub not working when called

[BGUNN]

delettesd.....

[LordLoki]

Hi Bgunn,

first you should put that code in Code tags.
I was generating a fake data Sheet as first sheet in the Workbook and the files where created
what i recognized is that the Data sheet was still empty i guess thats cause you always just use range(xy) instead of sth like WS.range where ws is the Worksheet you want the stuff to be done/taken from

If you post the workbook i can provide more help

[BGUNN]

Hi LordLoki,

Thanks very much for your reply. Code tags done.

I think I have managed to incorporate your suggestion regarding the range.
I have also uploaded the current version of my workbook to take up your offer of more help.

Regards
BGUNN

[BGUNN]

File Attached

[LordLoki]

will check that tomorrow its to late for me today

[Norie]

BGUNN

Which sub should be run first?

Also, why all the On Error... stuff? That justs hides errors.

[BGUNN]

BGUNN

Which sub should be run first?

Also, why all the On Error... stuff? That justs hides errors.

Hi Norie,
A_Findsheet runs first. On error was just in the syntax I leveraged. Does not seem to cause any issues. Feel free to make recommendations.
Thanks

[LordLoki]

Hi BGunn,

I think there is some kind of logical error inside your Worksheet but maybe i miss something.
All your subs are running perfectly fine you just seem to grab the wrong sheets
Can you explain what the Whole thing with the Temp Sheet and Copy is supposed to do?
Cause for me it looks like you don't need to do that in order to get your XML Files.

Check the Sheet attached and you see that you get xml files with the Data from the iTreAD_Notifications Sheet

[BGUNN]

Thanks LordLoki
You're right, I'm grabbing the wrong sheet.
I have not checked your workbook yet but I had success when I changed in the E_XLStoXML sub

Please Login or Register  to view this content.

to

Please Login or Register  to view this content.

I think (1) refers to the first worksheet not necessarily Sheet 1

I'll check out your sheet too when I can. Late for me here

The workbook is not quite finished yet but the Temp sheet is used to copy and flatten out data from the Query Task Manager sheet. The Notifications sheet references Temp to build up a list of "notifications" per row. The rows are generated to an xml format which is able to be processed by an external application which can then relay to a communications service provider. I'm turning raw data to Emails and SMS.

[LordLoki]

Ah then you came to the same conclusion then me.
I changed it to

Please Login or Register  to view this content.

that does the same to use the Sheet name is even better cause you don't get an error when someone messes with the Sheet order.

Looks like a nice project if you have any Questions or problems just give a shout

[BGUNN]

Great minds think alike!
A second pair of eyes always helps.

I'll be sure to let you know if I have any further questions.

Thanks for taking the time.