Macro saving files incorrectly

[Drexl27]

With help from the community I have the below (and attached) macro, but still have a slight problem with it that I can't find in the code. It is saving each group with the improper name, i.e. the file name indicating Group 'AP' has data for Group 'CFO' and 'CFO' has the data for Group 'CA' etc.

Sub SaveGroupFiles()
Dim x As Long
Dim stFolder As String, stFName As String
stFolder = ActiveWorkbook.Path
Range("Data").AdvancedFilter Action:=xlFilterCopy, copytorange:=Range("lst_group"), unique:=True
Application.DisplayAlerts = False
For x = 1 To Range("lst_group").Cells(1, 2)
stFName = Range("Crit").Cells(2, 1) & Format(Date, "mmddyyyy") & Format(Time, "hhmm")
Range("crit").Cells(2, 1) = Range("lst_group").Cells(x + 1, 1)
Range("Data").AdvancedFilter Action:=xlFilterCopy, copytorange:=Range("dataout"), criteriarange:=Range("crit")
Sheet3.Copy
ActiveWorkbook.SaveAs Filename:=stFolder & "\" & stFName
ActiveWorkbook.Close
Next x
End Sub


Thanks in advance for the help.

Copy of general 2015 percentages (3).xlsm

[Greg M]

Hi there,

Try the following code and see if it does what you need:

Please Login or Register  to view this content.

The basic problem was that the highlighted statement must be executed BEFORE a value is assigned to the variable "stFName".


Hope this helps - please let me know how you get on.

Regards,

Greg M

[Drexl27]

That was it, thank you very much!

[Greg M]

Hi again,

Many thanks for your prompt feedback - glad I was able to help.

Regards,

Greg M