Smart Indenter VBA on windows 64 bit

Originally Posted by YasserKhalil

Hope someone find a solution to this tool .. or alternative tool ..

Hello. I built a very simple add-in for code indentation, what works for me at 64-bits Excel, Word and AutoCAD, it here.

Oh, but it did go somewhere - the open-source Rubberduck project has ported the original VB6 source to C# (and then heavily refactored it); as a result all Smart Indenter settings are available, plus bug fixes and even additional settings, and work perfectly well in 32-bit and 64-bit VBA hosts.

...all Smart Indenter settings are available

Except one of the more useful features - Indent the entire project; indenting a procedure or module is fine but it's a pain to have to go back and do the project module by module which is essential when you pick up "something we tried to do ourselves..."

Other than that, and the fact it always crashed on exiting Excel (and I do realise that is documented with a fix somewhere) the only other downer is the need to actually have it analyze the project before you can do anything - but a very good start, none the less.

Bugs? I've never had an issue with, or noticed any bugs in, SI and that's using it since VB6 days (if not VB4 or 5 - too long ago to remember now).

@cytop Indenting the entire project is a trivial addition, we'll add it for next release - we haven't had any feedback asking about the missing feature, so it must have just slipped. I agree that the menus being disabled until the initial parse has started is annoying, but the commands actually get enabled as soon as parser state reaches "Parsing" - so you don't need to actually wait for it to complete (although, changing token positions while they're being processed is arguably a bad idea), and we'll enable the commands that aren't tied to parser state at startup, too - since the indenter doesn't use the parser state or parse trees, it'll be among the commands that will be available without processing anything... although we've moving towards an automatic initial parse, and I'm not sure which version you tried but processing performance v2.0.12 has nothing to do with v1.4.3 (which was slow as hell and blocked the UI thread).

If you haven't experienced any bugs with the original Smart Indenter, you haven't tried hard enough to break it!

Please Login or Register  to view this content.

It gets even more confused with `Function` and `Sub` type members, which are perfectly legal too. Fixed in Rubberduck's port.

Line continuations are also legal, and problematic (fixed in Rubberduck's port):

Please Login or Register  to view this content.

Instruction separators get mistaken for line labels (also fixed in Rubberduck's port):

Please Login or Register  to view this content.

It also happily lets you indent a line such that it ends up exceeding the maximum line length allowed in the VBE (1,024 characters) - see #2836 for all the details.

Originally Posted by rubberduckvba

Oh, but it did go somewhere - the open-source Rubberduck project has ported the original VB6 source to C# (and then heavily refactored it); as a result all Smart Indenter settings are available, plus bug fixes and even additional settings, and work perfectly well in 32-bit and 64-bit VBA hosts.

Rubberduck perfectly worked for MSOffice hosts, when I tested it "for recruiting", but it broke down in ours 64-bit AutoCADs 2014 while VBE loading, so, it was easier to write self own simple tool for universally use while that time. But I will test it again for later :-)

you haven't tried hard enough to break it

I never tried to break it - but I've never tried a line continuation character in an Type declaration either...

maximum line length allowed in the VBE (1,024 characters)

If a line is that long then shoot the programmer!

Instruction separators get mistaken for line labels

Have you ever tried to beep the speaker (Pathetic, I know) twice in VBA, or VB6/5/4/3/2/1...? (Must dig out VB2008 or later and test this again).

Please Login or Register  to view this content.

Smart Indenter is simply, and proudly, carrying on an established VBx/VBA tradition...

Can't remember the version I tried, but only downloaded it a couple of weeks ago and removed it last week but your proposed changes do address most of the niggles (only niggles) I had so will have another look at the latest.

Ta for that.

If a line is that long then shoot the programmer!

Definitely! Actually there are several number of edge cases we test for, for which the single most effective "fix" involves a 50,000 V / 500 amp discharge in the keyboard.. or mouse... lol

Interestingly, testing for these edge cases have given us a number of actual VBA grammar/parser bugs. For example you can have a legal line continuation just about anywhere, except in an "End Enum" token (they got that one right!). And did you know you can have a "Public Property" with a valid and perfectly legal and working "Exit Sub" statement, that ends with "End Function" or "End Sub"?

Working on Rubberduck has been (and continues to be) a very interesting learning experience

I'm responsible for the majority of the work on the C# port, and just pushed a commit that reinstates the Indent Project functionality. We did opt to leave the progress window out of the Rubberduck implementation though - my testing on a project with 112 code modules was completing the entire thing in around 15ms, so we figured it wasn't really needed...

If there's any other functionality that you'd like to see, just drop by our project on github and open an issue requesting it.