How to deal with multiple sets of code in the Initialize Event of a userform

[chin67326]

As we know, the Initialize Event of a userform is a very 'busy person', meaning for large and maybe complicated userforms with lots of things happening in them, we may need to equally have lots of things happening in the Initialize Event of a userform.

I am illustrating an example below in a 'less busy' userform but with a problem that can be encountered in a busier form with more data:

Below you will see the existing code in a userform, which essentially first displays a welcome message and then shows a userform:

ini1.png


Some new data needs to be added to the Initialize Event for the combobox function as shown below:

ini2.png

However the below error is received:

ini3.png

But the error is gone when the code is placed as below:

ini4.png

I have tried separating both codes with End Sub and End With etc. but no luck.

My question is, how are several codes in the Initialize Event usually separated (for example in this current example) rather than piling them on top of each other like I did to achieve resolution here? Some folks may go the other way and create an alternative way to code the comboboxes without using the Initialize Event, but in my opinion, running from matters like those gets rid of the symptoms, but the illness is still there.

The code is below and the workbook is attached. I appreciate your advice.

Please Login or Register  to view this content.

[Andy Pope]

Use a separate routine to store the code and call that in the event routine.

Please Login or Register  to view this content.

[peterspliid]

You can't ever put code outside subs or functions, unless it's a global definition.

You can add a sub, just for adding items to your combobox, and make it prettier by using the 'with' statement. If there is a lot of data, you could move it over to its own module, so its not visible in the code for UserForm1.

Please Login or Register  to view this content.

EDIT: Same as Andy said, i was too slow

[chin67326]

Use a separate routine to store the code and call that in the event routine.

Please Login or Register  to view this content.

Thanks guys. Both worked.

Andy, however in the below picture, when I place the cursor on the code in the Private Sub m_LoadComboBox(), the procedure window as shown by the red arrow does not say "Initialize" but says "m_LoadComboBox". Is it correct to say that the m_LoadComboBox still falls inside or within or under the overall "Initialize' umbrella, hence enabling the combobox to be populated when the userform is Initialized?

ini6.png

[Andy Pope]

The code is called by the m_LoadComboBox line in the initialize event.
So it routes out to execute that code and then returns to the initialize event and contines to execute those commands, such as the msgbox

[chin67326]

The code is called by the m_LoadComboBox line in the initialize event.
So it routes out to execute that code and then returns to the initialize event and contines to execute those commands, such as the msgbox

Thank you Andy, you good man. I understand this nicely now. Good day to you