how to change this for loop code to work from bottom up so it can delete rows

[vpan]

hi,
ive written this code to delete rows if Sheet 1 Column A matches Sheet 2 Column A (starting at row 12) and then if sheet 1 cell B5 also matches sheet2 column A.offset(0,1) (ie column B for corresponding row) to delete the rows from Sheet 1.
What I realized (this is my first project writing extensive VBA so only just being exposed to such problems) is that the cell references in column A mess up when a row is deleted and so it skips it and goes to the next. Googling this told me that I need to code from the bottom up to not have this error.

Im a little confused about the bottom up codes as its the first time ive seen it, can someone help me transform my code to reflect that?

Please Login or Register  to view this content.

[AB33]

It should be the other for loop. For each loop will result in infinite loop.

Please Login or Register  to view this content.

[vpan]

that makes things clearer

So ive changed the code to this

Please Login or Register  to view this content.

I am getting an error on this row "If WS1.Range("B5") = c.Offset(0, 1) Then 'If ID#s in both sheets are the same for the seller" which i was not getting got going top bottm and everyhing was running smoothly except deleting every other row.
Error says "Run-time error '91': Object vairable or with block variable not set"
Is the syntax wrong in my line or do i need to define something else? How do I fix this

[vpan]

I realized I need t o change to Set c = data.Find(Cells(i, "A")) 'Find seller in MasterSheet since i is long

So I did that and ran the code, but now if all the values exist in mastersheet, nothing in Add Request is getting deleted. I think my if logic syntax might be wrong so it thinks nothing matches both criteria?

[AB33]

Because c needs to be declared as a variable
You are also searching for a partial match

Please Login or Register  to view this content.

[kalbasiatka]

the variant with the dictionary

[vpan]

AB33 - Yeah I realized that and changed it too, but, for some reason it is not deleting any rows now even if both criteria exist in mastersheet. Is my if clause wrong in syntax?

[AB33]

Please attach a sample to see why your code is not working.

[vpan]

Sure here is a sample

[AB33]

Are the match exact or part match?

Please Login or Register  to view this content.

[vpan]

it should be exact

[AB33]

I have now adjusted and it works. I have also attached my own code. Both codes gives you a slightly different result. If there are duplicates, my code picks up the second duplicate while your code picks up the first duplicates.