My code is to slow for a large amount of numbers.

You only need one false flag:

Please Login or Register  to view this content.

Hello redab,

If you want to improve the speed you need to decrease the number of comparisons between the digits. Currently you are making 25 comparisons when it can be done in 7.

Please Login or Register  to view this content.

Hi Redsab,

Here is the site to read and learn about making your code faster.

http://www.cpearson.com/excel/optimize.htm

Hello readsab,

Question 1 - Did you change the integer value to long because the code can run long faster than an integer assignment?

Answer 1 - No, it is just habit. There are few times when I code that i need a "short" integer (Integer Type). This limits your range from -32768 to 32767.


Question 2 - 2. Is it assumed that if a function is false unless you assign it to true?

Answer 2 - Yes, initially the function's value is False. only if no integers are the same will True be returned.


Question 3 - I ran the code with the following values that should have been false but evaluated to true: {101,789}{789,101}{123,156}{123,416}{123,451}{123,245}{123,425}{123,452}

Answer 3 - This is the expected output for the macro I wrote. The name of the function is "No Duplicate Numbers". If you want it to return False then the return value can be switched but you should also change the function name to "Duplicate Numbers".

Hi RedSab,

Were there such a function, I believe that Leith or Jindon would know of it - I know of no such function

Leith, thank you for your help. I suppose I should call the function "NoDuplicateDigits". I didn't make my self fully clear of my output, sorry. What I should have said, was out of the six digits between 2-9 I can not have any of them the same. My ultimate project will print out a list of all the possible numbers that fit the following criteria: contain two 3-digit numbers where the sum of the two numbers are a 4-digit number and it uses all ten digits (0-9). Six of the digits will be the two numbers added together and the other four digits will be the answer. No duplications of digits in the summed numbers or the answer. I am just starting, so I have not programmed that far along yet. You have already taught me a few things. I appreciate it very much!
Thanks, redsab

jindon, I did not know that the variables would be Variant type the way I had them listed. I will change my habit! I have tested your code and it works exactly the way I need it. Thanks. I was excited to see the line:

Please Login or Register  to view this content.

I have never used a formula quite like that before, but after I thought about it, it made sense. I am a little confused about the following code:

Please Login or Register  to view this content.

I am not sure what the conditional IF statement is doing, could you elaborate on it a little? What is the concatenation going on? Thanks, redsab