send as pdf via outlook

1) Your code deals with one file but you listed two files here. I am going to suggest that you add an argument to the Sub and then pass in the desired file name.

Current Sub declaration:

Please Login or Register  to view this content.

Current code to set file name:

Please Login or Register  to view this content.

Current code that calls this Sub:

Please Login or Register  to view this content.

Revised Sub declaration:

Please Login or Register  to view this content.

Remove the lines of code shown above to set file name.

Revised code that calls this Sub:

Please Login or Register  to view this content.

2)
Just delete the line of code that displays the MsgBox.

You did not make the changes quite as I specified.

Somewhere outside of this Sub you have code that calls this Sub. It looks like this:

Please Login or Register  to view this content.

You have not provided your file or code so I have no idea where it is. To call it twice using the two cells you mentioned, you need to replace it with this:

Please Login or Register  to view this content.

Second, you have not changed the declaration of your sub.

You need to go step by step through my post #2 and make each change. If you want more help then please attach your actual file. Images of code are not very useful.

Originally Posted by smpita

Please Login or Register  to view this content.

This returns a range. You are trying to use a range as a string. You probably want this:

Please Login or Register  to view this content.

First, see my comment above. The code is simply in the wrong place, and no fix on these lines of code will work.

Second, a range reference can be used as a string. VBA objects each have a default attribute that is assumed when the object reference is used where an expression is expected. The default attribute of Range is Value. That means that if you use

Range("C3")

it is exactly the same as using

Range("C3").Value

(This is not true if Range is on the right side of a Set statement.) So syntax is not the problem.

Originally Posted by 6StringJazzer

The default attribute of Range is Value. That means that if you use

Range("C3")

it is exactly the same as using

Range("C3").Value

(This is not true if Range is on the right side of a Set statement.) So syntax is not the problem.

The only return for the Range() is a range object. https://msdn.microsoft.com/en-us/vba...e-object-excel
The only condition in which you can concatenate a string with an object is if you're not using the Explicit Option. Without this option being set, all variables are cast to variants unless explicitly declared. As variants, Excel capable of automagically correct these syntax errors.

It's generally considered good coding practices to take control of your data typing by setting the Explicit Option. People have a habit of suggesting its usage. If OP or some other person tries to use this snippet with the Explicit Option, it will not work. It is not the same. The provided code doesn't make it clear whether OP is taking advantage of the Explicit Option. You are obviously knowledgable in VBA and a valued member of this community. As a point of individual growth, I'd suggest you turn on Option Explicit and see the difference. It is also helpful for catching typos in your variables. You can do this by adding the following code block to the top of any module.

Note: It will only be enabled for that specific module.

Please Login or Register  to view this content.

Edit:

I accidentally linked the wrong document. I provided the one to the Range object, not to the Range(). Here is the documentation for the Range(). https://msdn.microsoft.com/en-us/vba...property-excel

Hey,

I am attaching my sample file.

All i want is to have a button in sheet "INVOICE" by which (macro code)

* I get a mail in pdf format of the excel file.
* The file name must be : "Range C3" & "Range Q2"

Originally Posted by anilpatni1234

* The file name must be : "Range C3" & "Range Q2"

This is not what you said in your first post:

filename1 = Range("C3").Text
filename2 = Range("Q42").Text

I would be happy to directly modify your file but only if we get the description right first. If you want one file, things are very, very simple compared to the code I posted above.

Works fine for me.

Please Login or Register  to view this content.

Glad to help and thanks for rep+.

If that takes care of your original question, please select Thread Tools from the menu link above and mark this thread as SOLVED. Thanks.