Animate a Logo; Visual component failure

[jomili]

Okay it's got to be easy, but I can't figure it out. I've had the attached for a few years, and hadn't tried it out on 2013 Excel until today. The whole idea is to shrink and spin the logo. If I walk through the macro it does just that. However, if I run the macro I can't see anything happen. All code is in the "ThisWorkbook" module. I'd sure appreciate it if anyone can help with this.

Thanks,
Jomili

[mjr veverka]

To not change the code too much, in my opinion:
1. Slow down the loops in functions and throw away "Application.ScreenUpdating = False/True"
2. "Shape.Visible = True" in functions can be blocked/commented
3. Functions to transfer to the "standard" module

try maybe e.g.:

1. ThisWorkbook module:

Please Login or Register  to view this content.

2. Standard module:

Please Login or Register  to view this content.

[jomili]

Thanks Porucha. Going with your suggestions I've removed the "ActiveSheet.Shapes("Picture 2").Visible" TRUE and FALSE lines, and removed the Screenupdating lines. I like the way you threw in the "one_moment_please" timer to slow down the action; I thought that might be the issue, but wasn't sure how to address it. Not sure how "one_moment_please" and "cntrlr" work together; you start "cntrlr" with a value of .06, then allow "one_moment_please" to run until it's value exceeds "cntrlr" + .44. Would you mind explaining the logic behind that and how it all works together?

[mjr veverka]

1.

Please Login or Register  to view this content.

This "cntrlr + 0.44" (= 0.5 s, where cntrlr = 0.06) is just a delay in showing the "Spin" button, it's only local.
It does not take part in the operation of the functions.

2.

Please Login or Register  to view this content.

Regarding (As for the ... ?) 'DoEvents' function, you can get more information from the Ms contextual help, than from me with my poor English.
"Do While Timer - one_moment_please < cntrlr" is just an ordinary loop that works for as long as the condition is met.
'DoEvents' transfers control to the system, which allows you to complete the collected tasks. It's a kind of task retarder without too much suspending the system.

[Andy Pope]

I just added a couple of DoEvents inside the loops and it works.

If you want to slow things done you could make use of the Sleep API.

Please Login or Register  to view this content.