Results 1 to 4 of 4

For Loop Execution Incomplete!!

Threaded View

  1. #1
    Registered User
    Join Date
    10-11-2018
    Location
    Bangalore
    MS-Off Ver
    2016
    Posts
    10

    For Loop Execution Incomplete!!

    Hello,

    I have written a code to generate a table from sheet2 to sheet1. Data is getting updated only for P34 value in sheet1 instead of getting updated for all the values under P34 until the next blank cell which is currently not happening.

    Please, could anyone help me as I have got stuck and unable to figure the actual cause for the incomplete loop? Attached macro sheet as well for detailed reference.

    Sub testing()
    
    Dim Loopx As Integer
    Dim ChklstCounter As Integer
    Dim InpDtCounter As Integer
    Dim CopyText As String
    Dim CopyText1 As String
    Dim wb As Workbook
    Dim wb1 As Workbook
    Dim FindRowx As Range
    Dim FindRowNumber As Long
    Dim Startrowcount As Integer
    Dim DataFound As String
    Dim LInpDtCounter As Integer
    Dim lastrow As Integer
    Dim Lastrow_Input As Integer
    Dim LOB_Findstrng As String
    Dim LOBFindRow As Range
    Dim LOBFindRowNumber As Long
    Dim LOBNmDataFound As String
    Dim CopyTextDel As String
    Dim CopyTextDel1 As String
    Dim INCR As Integer
    
    Lastrow_Input = ThisWorkbook.Sheets(2).Range("A1").End(xlDown).Row
    LInpDtCounter = 2
    
        LOB_Findstrng = ThisWorkbook.Sheets(2).Range("D2").Value
        Set LOBFindRow = ThisWorkbook.Sheets(3).Range("A:A").Find(What:=LOB_Findstrng, LookIn:=xlValues)
        LOBFindRowNumber = LOBFindRow.Row
        LOBNmDataFound = ThisWorkbook.Sheets(3).Range("A" & LOBFindRowNumber).Offset(0, 1).Value
    
    Set wb1 = ThisWorkbook
    With wb1.Sheets(1)
        Set FindRowx = .Range("B:B").Find(What:=LOBNmDataFound, LookIn:=xlValues)
        FindRowNumber = FindRowx.Row
        Startrowcount = .Range("B" & FindRowNumber).Offset(5, 14).Row
        DataFound = .Range("B" & FindRowNumber).Offset(5, 14).Value
        lastrow = .Range("P" & Startrowcount).End(xlDown).Row
        LInpDtCounter = 2
     
    For INCR = Startrowcount To lastrow
    For LInpDtCounter = 2 To Lastrow_Input
    'Debug.Print (INCR);
    'Debug.Print (lastrow);
    
         
         If ThisWorkbook.Sheets(1).Range("P" & INCR).Value = ThisWorkbook.Sheets(2).Range("I" & LInpDtCounter).Value Then
                If (ThisWorkbook.Sheets(1).Range("P" & INCR).Value) <> "" Then
                  If ThisWorkbook.Sheets(2).Range("H" & LInpDtCounter).Value = "Marketed" Then
                
                     If ThisWorkbook.Sheets(1).Range("E" & INCR) <> "" Or ThisWorkbook.Sheets(1).Range("F" & INCR) <> "" Then
                        
                        ThisWorkbook.Sheets(1).Range("E" & INCR).Select
                        ActiveCell.Offset(1).EntireRow.Insert Shift:=xlDown
                        
                        Application.CutCopyMode = False
                        ThisWorkbook.Sheets(1).Range("B" & INCR + 1).Select
                        Selection.FillDown
                        ThisWorkbook.Sheets(1).Range("C" & INCR + 1).Select
                        Selection.FillDown
                        
                        ThisWorkbook.Sheets(1).Range("D" & INCR + 1).Select
                        Selection.FillDown
                        ThisWorkbook.Sheets(1).Range("O" & INCR + 1).Select
                        Selection.FillDown
                        ThisWorkbook.Sheets(1).Range("P" & INCR + 1).Select
                        Selection.FillDown
                        CopyText = ThisWorkbook.Sheets(2).Range("J" & LInpDtCounter).Value
                        CopyText = Split(Split(CopyText, "Current term content(s):")(1), "Reference document content(s):")(0)
                        CopyText = Replace(CopyText, Chr(10), "")
                        ThisWorkbook.Sheets(1).Range("E" & INCR + 1) = CopyText
                        CopyText1 = ThisWorkbook.Sheets(2).Range("J" & LInpDtCounter).Value
                        CopyText1 = Split(Split(CopyText1, "Reference document content(s):")(1), "")(0)
                        CopyText1 = Replace(CopyText1, Chr(10), "", , , vbTextCompare)
                        ThisWorkbook.Sheets(1).Range("F" & INCR + 1) = CopyText1
                        ThisWorkbook.Sheets(2).Range("M" & LInpDtCounter).Copy Destination:=ThisWorkbook.Sheets(1).Range("H" & INCR + 1)
                        ThisWorkbook.Sheets(2).Range("N" & LInpDtCounter).Copy Destination:=ThisWorkbook.Sheets(1).Range("I" & INCR + 1)
                    
                     ElseIf ThisWorkbook.Sheets(1).Range("E" & INCR) = "" Or ThisWorkbook.Sheets(1).Range("F" & INCR) = "" Then
                        CopyText = ThisWorkbook.Sheets(2).Range("J" & LInpDtCounter).Value
                        CopyText = Split(Split(CopyText, "Current term content(s):")(1), "Reference document content(s):")(0)
                        CopyText = Replace(CopyText, Chr(10), "")
                        ThisWorkbook.Sheets(1).Range("E" & INCR) = CopyText
                        CopyText1 = ThisWorkbook.Sheets(2).Range("J" & LInpDtCounter).Value
                        CopyText1 = Split(Split(CopyText1, "Reference document content(s):")(1), "")(0)
                        CopyText1 = Replace(CopyText1, Chr(10), "", , , vbTextCompare)
                        ThisWorkbook.Sheets(1).Range("F" & INCR) = CopyText1
                        ThisWorkbook.Sheets(2).Range("M" & LInpDtCounter).Copy Destination:=ThisWorkbook.Sheets(1).Range("H" & INCR)
                        ThisWorkbook.Sheets(2).Range("N" & LInpDtCounter).Copy Destination:=ThisWorkbook.Sheets(1).Range("I" & INCR)
                     End If
                  ElseIf ThisWorkbook.Sheets(2).Range("H" & LInpDtCounter).Value <> "Marketed" Then
                       If ThisWorkbook.Sheets(1).Range("P" & INCR).Value = ThisWorkbook.Sheets(2).Range("I" & LInpDtCounter).Value Then
                         If ThisWorkbook.Sheets(1).Range("E" & INCR) <> "" Or ThisWorkbook.Sheets(1).Range("F" & INCR) <> "" Then
                            Application.Goto ThisWorkbook.Sheets(1).Range("A1")
                            ThisWorkbook.Sheets(1).Range("E" & INCR).Select
                            ActiveCell.Offset(1).EntireRow.Insert Shift:=xlDown
                            
                            ThisWorkbook.Sheets(1).Range("E" & INCR + 1).Select
                            ThisWorkbook.Sheets(1).Range("B" & INCR + 1).Select
                            Selection.FillDown
                            ThisWorkbook.Sheets(1).Range("C" & INCR + 1).Select
                            Selection.FillDown
                            ThisWorkbook.Sheets(1).Range("D" & INCR + 1).Select
                            Selection.FillDown
                            ThisWorkbook.Sheets(1).Range("O" & INCR + 1).Select
                            Selection.FillDown
                            ThisWorkbook.Sheets(1).Range("P" & INCR + 1).Select
                            Selection.FillDown
                            CopyText = ThisWorkbook.Sheets(2).Range("J" & LInpDtCounter).Value
                            CopyText = Split(Split(CopyText, "Current term content(s):")(1), "Reference document content(s):")(0)
                            CopyText = Replace(CopyText, Chr(10), "")
                            ThisWorkbook.Sheets(1).Range("E" & INCR + 1) = CopyText
                            CopyText1 = ThisWorkbook.Sheets(2).Range("J" & LInpDtCounter).Value
                            CopyText1 = Split(Split(CopyText1, "Reference document content(s):")(1), "")(0)
                            CopyText1 = Replace(CopyText1, Chr(10), "", , , vbTextCompare)
                            ThisWorkbook.Sheets(1).Range("G" & INCR + 1) = CopyText1
                            ThisWorkbook.Sheets(2).Range("M" & LInpDtCounter).Copy Destination:=ThisWorkbook.Sheets(1).Range("H" & INCR + 1)
                            ThisWorkbook.Sheets(2).Range("N" & LInpDtCounter).Copy Destination:=ThisWorkbook.Sheets(1).Range("I" & INCR + 1)
                         
                         ElseIf ThisWorkbook.Sheets(1).Range("E" & INCR) = "" Or ThisWorkbook.Sheets(1).Range("F" & INCR) = "" Then
                            CopyText = ThisWorkbook.Sheets(2).Range("J" & LInpDtCounter).Value
                            CopyText = Split(Split(CopyText, "Current term content(s):")(1), "Reference document content(s):")(0)
                            CopyText = Replace(CopyText, Chr(10), "")
                            ThisWorkbook.Sheets(1).Range("E" & INCR) = CopyText
                            CopyText1 = ThisWorkbook.Sheets(2).Range("J" & LInpDtCounter).Value
                            CopyText1 = Split(Split(CopyText1, "Reference document content(s):")(1), "")(0)
                            CopyText1 = Replace(CopyText1, Chr(10), "", , , vbTextCompare)
                            ThisWorkbook.Sheets(1).Range("G" & INCR) = CopyText1
                            ThisWorkbook.Sheets(2).Range("M" & LInpDtCounter).Copy Destination:=ThisWorkbook.Sheets(1).Range("H" & INCR)
                            ThisWorkbook.Sheets(2).Range("N" & LInpDtCounter).Copy Destination:=ThisWorkbook.Sheets(1).Range("I" & INCR)
                         End If
                       End If
                  End If
             End If
         End If
        
    Next LInpDtCounter
    Next INCR
    
    End With
    
    End Sub
    Attached Files Attached Files

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. Loop Execution--Questions
    By VBNewb in forum Excel Programming / VBA / Macros
    Replies: 6
    Last Post: 06-27-2011, 01:03 PM
  2. Incomplete Range
    By sglick in forum Excel Programming / VBA / Macros
    Replies: 2
    Last Post: 06-05-2007, 04:49 PM
  3. Speeding up the Execution of an SQL query in a VBA loop?
    By gimiv in forum Excel Programming / VBA / Macros
    Replies: 0
    Last Post: 05-15-2007, 03:31 PM
  4. Stopping repetitive loop execution through user form (or other ide
    By Mike in forum Excel Programming / VBA / Macros
    Replies: 8
    Last Post: 08-18-2006, 01:00 AM
  5. oldest incomplete job
    By floridasurfn in forum Excel Formulas & Functions
    Replies: 3
    Last Post: 07-11-2006, 01:45 PM
  6. excel tip incomplete
    By rss in forum Excel Programming / VBA / Macros
    Replies: 1
    Last Post: 06-23-2006, 09:00 PM
  7. incomplete code
    By tim64 in forum Excel Programming / VBA / Macros
    Replies: 7
    Last Post: 06-20-2005, 08:05 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Search Engine Friendly URLs by vBSEO 3.6.0 RC 1