Code better or faster?

[Frigide]

I wrote my own script. It works like a charm. My question you think?

Can it be cleaner, better or faster!

Please Login or Register  to view this content.

[dflak]

It certainly looks like a reasonable bit of code and unless it is in some sort of loop where it gets executed thousands of times, my suggestions won't save any noticeable amount of time, but here they are nonetheless.

First is to set a pointer to the sheets instead of using the sheet names themselves.

Please Login or Register  to view this content.

I do not know if this saves any time in code execution, but it does save typing and it does declutter the code. Also once set, the pointer remembers what workbook it belongs to, so if you have other workbooks open, you don't have to worry if sh is in the active workbook.

The other thing is that I don't like to do the same calculation more than once whether it be in code or in a formula on a worksheet. What I suggest as cleanup is

Please Login or Register  to view this content.

As I mentioned above, this probably won't matter unless you are doing it a thousand or so times.

At least it looks cleaner.

[Frigide]

dflak,

Thanks for the reply. I changed it to

Please Login or Register  to view this content.

Is there a faster wat to unlock en lock several sheet i call in the macro.

Please Login or Register  to view this content.

[Frigide]

Found a script that run all sheets to protect and unprotect.
This is the macro now. Thanks all.

Please Login or Register  to view this content.

[dflak]

See also this:
https://stackoverflow.com/questions/...dcmZSeU77gw&e=

[Frigide]

That helpt a lot! Smoother and more protected.

3 week ago i didn't now what a macro or what VBA was. Nice dudes!!

[Frigide]

Please Login or Register  to view this content.