nested loops overwriting

[mbydl2]

Hi! I have written this piece of code below but the issue is that the values returned are only for the final year and the final day for each plant because they keep overwriting. I have tried to incorporate into a collection as string and then split but that returns the same values for year 1 and year 2 rather than performing the calculation again i.e value at plant 1, day 1 year 1 will be the same as plant 1 day 1 year 2. Even though i know where the problem seems to be, i'm not sure how to fix it. I'm really knew to VBA so any advice ould be greatly appreciated

Thanks a lot!

Please Login or Register  to view this content.

Moderator's note: Please take the time to review our rules. There aren't many, and they are all important. Rule #2 requires code tags. I have added them for you this time because you are a new member. --6StringJazzer

[6StringJazzer]

You are using p to index the array, but p is just the innermost loop, so you'll use the same slots for every year, every day. You need to take into account year and day as well, and you only need one loop, not three nested ones.

You also need to specify that the first dimension starts at 1, unless you are using Option Base 1.

I can't test this because you are not showing how you set npatches and patchsize, flowering, floweringSD. Also, you should declare year and day; better yet, name them something else. It works, but there are built-in functions called Day and Year and you don't want to tempt confusion. I strongly recommend to everyone that they declare variables. Doing so prevents a lot of bugs and runtime errors.

Please Login or Register  to view this content.

[JLGWhiz]

it is not over writing. The statement to enter the data is in the wrong place. See the edited version below.

Please Login or Register  to view this content.

Also, you need to change your 'Year' and 'Day' variables to something else. Both of those are Excel and VBA keywords that considered reserved. The code might run with them in use but results may be less than desirable. I woulr you something like 'yr' and 'dy' which still pretty much represents what you want.

I see that @6StringJazzer went a little deeper into analysis than I did.

[mbydl2]

6StringJazzer I was not aware of the day and year built in functions. I have now renamed the variables so thank you for that! The code you have providiied doesn't seem to be working as a syntax error highlighting the Lbound(plants, 1) to Ubound(plants, 1) section appears. It's also worth mentioning that I did want the code to run the operations for each of the 30 plants for 80 days meaning that i would expect the values returned to be the same for plant 1 for 80 days until the operations begin for the next plant. After the operations are ran for all the 30 plants for 80 days each, next year begins (where i would like for the values to differ from the previous year). Apologise if that wasn't very clear from my thread.

npatches = 3
patchsize = 100
flowering = 50
floweringSD = 10

[mbydl2]

JLGWhiz that doesn't seem to be working. Same thing happens :/