using cmd by vba macro

[quirkybox]

Hello Guys,

Please Login or Register  to view this content.

This macro has issues, It works sometimes & sometimes it didn't work
I am unable to find the problem of this macro
Plz Have a look Sir\Mam

Thnx

[BMV]

Why not simple?
Shell "cmd /c start C:\Users\WolfieeeStyle\Desktop\WolfieeeStyle\9.15\Close Excel.lnk"", vbHide

[quirkybox]

I got this macro by doing google searches
I am looking for a macro that if file exist

Please Login or Register  to view this content.

then first move the file to

Please Login or Register  to view this content.

& run the close excel.lnk nothing else I need & if the file is not located then do nothing

Please Login or Register  to view this content.

[quirkybox]

I putted this Shell "cmd /c start C:\Users\WolfieeeStyle\Desktop\WolfieeeStyle\9.15\Close Excel.lnk"", vbHide
& i run the macro but not getting any output

[BMV]

What output you expect? what is the Close Excel.lnk command?

[quirkybox]

output means
I am looking for a macro that if file exist

Please Login or Register  to view this content.

then first move the file to

Please Login or Register  to view this content.

& then run the close excel.lnk & if the file is not located

Please Login or Register  to view this content.

then do nothing
close excel is what (i putted this taskkill /F /IM EXCEL.EXE to notepad & save it as a .bat file & i created a shortcut link of that .bat file to desktop & named that file to close excel.lnk
Y i created a shorcut link is whenevr i run that close excel.bat then it doesn't work if i run that close excel.bat by administrator then it works , so i created a shortcut link of closeexcel.bat which is close excel.lnk & from settings i assigned that to always run by administrator , so whenevr it will be run then it will run as admin & everything will be perfect

[BMV]

You can start taskkill directly from shell without lnk.

[quirkybox]

If u mean to say that opening task manager & kill all the excel file then yes i can do that but i am not looking for manual work bcoz i have to do this 4 times a day & 365 days of a year then this will not be a great Idea Sir
I am looking for macro (automation. no manual work from my end )

[vba_php]

QB,

there are a few ways to run the CMD with this coding environment. this was written long ago by me and has worked fine ever since. maybe you can get something from it:

Please Login or Register  to view this content.

this is the website that is most helpful for running DOS commands, IMO:

https://www.computerhope.com/msdos.htm

[quirkybox]

Bro i saw this

Please Login or Register  to view this content.

I dont know what to do with this & i never used such type of macros nor i have any idea of such type of macros & u know the condition also of the macro so plz help me for the same, i am not a professional vba coder sir so plz help


& one more thing u have used xcopy & there is no copy paste in this problem Sir

[vba_php]

you don't know how to do what exactly? you have to be specific. that's the biggest quirk of professionals. ha ha. SPECIFICS! so....here are some questions to ask:

=> what is a public function?
=> where do I put this code in my workbook?
=> what does that code do?
=> what do the comments mean? what is "strArg"?

see where I'm going with this? I've heard people say "I don't how to use that" for 20 years, and that doesn't help an experienced person help *you*. Can you clarify?

[quirkybox]

Please Login or Register  to view this content.

I puted this macro to macro.xlsm & I dont know anything about public function,strArg I got this macro from google search



I know what macro should do
The condition are below what i have to do & what macro should do

First it should check wheather close excel.lnk is located here or not C:\Users\WolfieeeStyle\Desktop
If not located then do nothing

& if Close Excel.lnk is located at C:\Users\WolfieeeStyle\Desktop then first move the close excel.lnk to C:\Users\WolfieeeStyle\Desktop\WolfieeeStyle\9.15\
& then run the close excel.lnk


If my macro is not proper then plz change it

[BMV]

Please Login or Register  to view this content.

[vba_php]

some others here have tried to help, so I'm maybe I'm stepping on their toes. but maybe we're close. here's what I see. this....

Please Login or Register  to view this content.

...is fine if the shortcut IS actually at that address. this....

Please Login or Register  to view this content.

....should work fine. dir returns what you are checking. this....

Please Login or Register  to view this content.

....should also work fine, per this: https://docs.microsoft.com/en-us/off...ovefile-method

this....

Please Login or Register  to view this content.

.....is a wildcard.

so, set some breakpoints in the code and tell us exactly which line of code is offending (not working). can you do that?

[quirkybox]

Please Login or Register  to view this content.

I used this & this is working perfect
Awesome Bro
What a Idea

Awesome Solution Sir
Have a Great Day,Awesome Day Sir
Problem Solved

[vba_php]

I replicated your issue with the same directories, and this works just fine for me:

Please Login or Register  to view this content.

this also works just fine for me (this is MOVING the file, not COPYING it):

Please Login or Register  to view this content.

so obviously the FSO object works fine. I think what you were missing, is that you were running this line:

Please Login or Register  to view this content.

when you move a file either with the file scripting object in VBA or with the CMD shell, you HAVE to include the file name and extension too! goofy. did this solve it now?

[quirkybox]

Sir i deleted that close file.lnk & close file.bat file
bcoz the below macro close the excel, so now i dont need that .bat file & .lnk file

Please Login or Register  to view this content.

this macro is perfect for me
Yes No Doubt Problem Solved Sir

[BMV]

@quirkybox Thanks for rep. Some times we must ask how to get aim but not how to correct wrong and difficult way :-)

If you would like to close application without any question then you can use

Please Login or Register  to view this content.

[quirkybox]

Ithink no need to use this

Please Login or Register  to view this content.

bcoz when we are using the below macro then In any condition excel will close itself without any question or pop up

Please Login or Register  to view this content.

Sub STEP2()
shell "taskkill /F /IM EXCEL.EXE"
End Sub

Please Login or Register  to view this content.

[vba_php]

good! good luck to you! oh, and don't call me sir. I'm only 40 years old.

[quirkybox]

Ok No Problem Bro
Thnx

[BMV]

@quirkybox. Think about compatibility.
The last code will work on the MacOS also. The taskkill available only for Windows system.

[quirkybox]

No Doubt, I will go with the windows only & i am satisfied with the macro that i have recv
Thnx for providing the Great Info To me Sir

[quirkybox]

Please Login or Register  to view this content.

I made this macro Sir
Reason i made this macro is bcoz the logic which i used was not correct
I sent u this macro only to see is this macro correct, is there any error in the macro then plz let me know
Just see this macro has any errors or Any modifcation is needed as per u ?



This macro does the same what i want to do
only i have shared the macro to let u know that plz check the macro & plz let me know is it perfect or not