hundreds of workbooks left open (speed issue)

[vba_php]

I have to loop through 342 records in a book. and I am creating new workbooks based on data found in these recs. but not every rec will create a new book. if a book was previously created and subsequent duplicate data is found, the I/O stream will simply add that rec's data to the newly-created book previously. but can anyone here tell me if leaving ''x'' books open for the purpose I described would be a hinderance for the application? I mean, in terms of stack availability and heap issues, I don't think there is any, because books that are opened take no memory other than the mem. space for their object var. and an I/O stream doesn't take anything either. does anyone have any suggestion as to whether that would be a better method than the below code, which I am currently using? I would think that obviously it would be, for obvious reasons. I have a plan already, but I am just looking for input from the real pros that are around here, because I generally don't do this type of work. thanks!

Please Login or Register  to view this content.

[jolivanes]

Things like this certainly are not good for a speedy macro.

Please Login or Register  to view this content.

As far as your problem about the workbooks being open, I don't have an answer to that at all but it would be interesting to see the differences if you incorporate a timer in different macros.

[vba_php]

Are you talking about logging the complete execution time regarding the different code routines that I have already written in my plan that I mentioned? Because if that's what you're talking about the code I wrote during the first version of this product that I returned to this employer I already created an in-out stream and logged errors and that includes the total execution time of the routine

[jolivanes]

I was under the impression that it was a one book exercise. Apparently not. Sorry about that.

[vba_php]

well yes it is. the code is executing behind ONE book. however, 4 books are open when the code stars running, and additional books are generated, per what we've already talked about, as the code goes through execution.

[rorya]

It would be more efficient to collate all the data for a particular workbook at once, create it, close it, and move on.

[vba_php]

yes I know that Rorya. and that is what I will eventually end up doing because it does not make sense whatsoever to loop the recs without sorting them first. either that or using the .find methods in an un-sorted situation. and, if you're interested, I also had a question about another issue related to this here:

https://www.excelforum.com/excel-pro...a-project.html

[rorya]

If you know that, why did you ask the question?

[vba_php]

Probably because I don't know everything that's why LOL even though I may sound like a smart-*** sometimes on the forum and may even say things on a deep level and no one else understands it doesn't mean that I'm God I mean you're better than I am in a lot of areas and so are a lot of other people here

[vba_php]

And I find it comical that my trailing semi cuss word was censored I assume that was cloud fair that did that?