I'm looping over a document, finding all the hyperlinks, checking to see if they contain the word "Figure" or "Table" and if they do, removing the hyperlink and changing the text to black. This works, but it only catches some of the hyperlinks on the first run. Then it catches more on the next run, more on the next run, etc. I have to run it 5-6 times to catch all instances.
How can I fix this to catch all instances on the first run?
Please Login or Register to view this content.
Untested here !
Will this work ? Only this macro ... do not use the others in your post.
Please Login or Register to view this content.
In your example, where does link_set get passed in from?
I made the macro much simpler but it's still doing the same thing. I need to run it several times to catch all instances.
Please Login or Register to view this content.
Anyone have an answer for why this is happening? I ended up band-aiding a fix for this to get it working. I set a variable at the start of my function equal to ActiveDocument.Hyperlinks.Count and then I check that value again at the end of the function. If the two values are not equal, it means some links were stripped off. So I call the function again and repeat everything. I keep calling the function over and over until finally the starting link count equals the ending link count - this means no links were stripped off during this last loop and so we must be done.
Usually it has to call itself about 6-8 times until it's deleted all the links. This isn't how it should work. Luckily the script only takes a few seconds, but I still really wish I understood why it's happening.
Attach a sample workbook, it will be easier to find the cause of the problem.
Artik
Good idea - here it is: https://www.excelforum.com/attachmen...1&d=1625585279Originally Posted by Artik
Run the macro called "RUN_THIS_ONE()"
I have this example set to remove links containing the words: park, baby, elephant, asia,species,afr,cavity
On my computer it has to re-run the function 3 times before it is able to strip away all 155 of the links with those words.
Last edited by kandiyohiv; 07-06-2021 at 11:34 AM.
This link is not working! Read and apply the suggestion shown in the yellow banner at the beginning of the thread.
Artik
I thought I did... Either I'm doing something wrong or something isn't working. I click on "manage attachments" and then upload the file from my computer. Initially it shows that it added (which is how I grabbed the link to the file). I even tested downloading it to make sure it worked (it did) but then if I go back to "manage attachments" later it shows I have no attachments. I tried from Edge, Chrome, IE and even tried from my home computer (instead of work computer) to make sure it isn't being blocked by my work's security team. Same results in all scenarios.
elephants.png
2021-07-06_13-25-14.png
Last edited by kandiyohiv; 07-06-2021 at 01:26 PM.
Try:
1. Click [Choose file] button
2. After the file selection window is closed, click [Upload] button
3. Click [Close this window] button
4. And finally, click [Submit Reply].
Artik
Trying again
Hmm, and I thought all the time we were going to talk about Excel, and here is such a surprise. OK, if it has to be done, it will be done.
Watching the macro work, I noticed that it removes every other hyperlink with one run. This reminds me of the problem of deleting rows in Excel. If we use an ascending loop, some rows may be omitted, therefore a descending loop is used.
And likewise here. This loop should be used. Only change at the beginning of one procedure:ArtikPlease Login or Register to view this content.
Thank you so much for your help. Sorry about the slow response, I was on vacation. I have marked this as solved.
There are currently 1 users browsing this thread. (0 members and 1 guests)
Posting Permissions
LinkBack URL
About LinkBacks
Register To Reply
Bookmarks