Loop with selection.delete and InStr is ending early

This works:

Please Login or Register  to view this content.

EXCEPT ... I am at a loss to explain why cell C3 is skipped in the second loop.

$A$2:$A$18
$A$2 Hamilton : Hamilton-Wentworth
$A$3 Hamilton : Hamilton-Wentworth
$A$4 Dundas : Hamilton-Wentworth
$A$5 Stoney Creek : Hamilton-Wentworth
$A$6 Hamilton : Hamilton-Wentworth
$A$7 425 WILSON ST E
$A$8 Flamborough : Hamilton-Wentworth
$A$9 Dundas : Hamilton-Wentworth
$A$10 Flamborough : Hamilton-Wentworth
$A$11 135 HWY 8
$A$12 UNITS C11 & C1A
$A$13 Hamilton : Hamilton-Wentworth
$A$14 Dundas : Hamilton-Wentworth
$A$15 Hamilton : Hamilton-Wentworth
$A$16 Hamilton : Hamilton-Wentworth
$A$17 Hamilton : Hamilton-Wentworth
$A$18 Hamilton : Hamilton-Wentworth
$C$2:$C$18
$C$2 street photos:*1*2*3*4*5*6*7*8*9*10*11*12*13*14*15*16*17*18*19*20*21*22*23*24*25*26*27
$C$4 street photos:*1*2*3*4*5*6*7
$C$5 street photos:*1*2*3*4*5*6*7*8*9*10*11*12*13*14*15*16*17*18
$C$6 street photos:*1*2*3*4*5*6*7*8*9*10*11*12*13*14*15*16*17
$C$7
$C$8 street photos:*1*2*3*4*5*6*7
$C$9 street photos:*1*2*3*4*5*6*7
$C$10 street photos:*1*2*3*4*5*6
$C$11
$C$12
$C$13 Transferor(s)
$C$14 street photos:*1*2*3*4*5
$C$15 street photos:*1*2*3*4*5
$C$16 street photos:*1*2*3*4*5
$C$17 street photos:*1*2*3*4*5
$C$18 Transferor(s)

Seem like deleting the first cell C2 on range "C2:C18" cause the C3 to skip
Change C2 to C1 fix it

Please Login or Register  to view this content.

or try

PHP Code: 

Sub cUp()

Dim a, i&
a = [a1].CurrentRegion.Value
For i = 1 To UBound(a)
    If InStr(a(i, 1), ":") Then
        If InStr(a(i, 2), "photo") = 0 Then
            a(i, 4) = a(i, 3)
            a(i, 3) = a(i, 2)
        End If
        a(i, 2) = a(i, 1)
        a(i, 1) = Empty
    End If
Next
[a1].CurrentRegion.Value = a
End Sub 


@Bo_Ry/Artik: thanks for the workarounds. I am still intrigued that the "fail" is inconsistent. If the loop had missed other cells, I could understand it to a certain extent and then the traditional workaround of working from the bottom up would make more sense. But just one cell near the top of the loop is very confusing.

Anyway, my workaround

Please Login or Register  to view this content.

Not sure which solution you opted for. My first solution was close but, for some reason, missed a cell out in the second loop. That might have been masked in your live file. My second solution works ok.

I'm guessing the solutions offered by Bo_Ry and Artik worked but I didn't test them.

You don't need to type any solutions; you can copy and paste them.



If you are satisfied with the solution(s) provided, please mark your thread as Solved.


New quick method:
Select Thread Tools-> Mark thread as Solved. To undo, select Thread Tools-> Mark thread as Unsolved.

Or you can use this way:

How to mark a thread Solved
Go to the first post
Click edit
Click Go Advanced
Just below the word Title you will see a dropdown with the word No prefix.
Change to Solved
Click Save


You may also want to consider thanking those people who helped you by clicking on the little star at the bottom left of their reply to your question.

You're welcome. Thanks for the rep.