Hide Unhide Yellow Sheets Code Error

[BillySpivy]

Hello,

On the Monthly Budget sheet there are purple shapes labeled "H" and "U" which are supposed to hide the sheets with tab color yellow or unhide them. These are not working now and I don't know why.

Can someone please see how to fix?

Thank you very much

[Richard Buttrey]

In the Ribbon 'Review' Menu the Workbook is showing as protected. Click the 'Protect Workbook' icon to unprotect.

As for the macro I generally find it's not a good idea to have code that is dependent on the colour of something. Personally I'd use the ws.Name i.e. "Transactions" in the If test.

[BillySpivy]

Can unprotect be added to the codes in some way then reprotect?

[BillySpivy]

I added these to the codes and it seemed to work thanks.

Thisworkbook.Unprotect
Thisworkbook.Protect

[Richard Buttrey]

Top and tail your Hide_Yellow_SHeets macro with

ActiveWorkbook.Protect Structure:=False, Windows:=False

ActiveWorkbook.Protect Structure:=True, Windows:=False

Incidentally using the Tab.Color code isn't actually doing anything. As I said you'd be better advised to test the tab name or some other unique characteristic.

Incidentally the ws.Visible = xlSheetHidden instruction is processed every time the ws.Name changes.
There's no reason to have a loop at all. You might just as well hide the sheet directly as the one and only instruction,

[BillySpivy]

I appreciate the advice but I frequently need to unhide the group of sheets then hide them again. If I have to do this for each sheet it is too time consuming.

Have a great day!

[Richard Buttrey]

I appreciate the advice but I frequently need to unhide the group of sheets then hide them again. If I have to do this for each sheet it is too time consuming.

Have a great day!

I don't understand your comment. It's the macro that does the hiding & unhiding. Where did I ever suggest you needed to do this for each sheet - presumably you mean manually.

[BillySpivy]

I don't understand your comment. It's the macro that does the hiding & unhiding. Where did I ever suggest you needed to do this for each sheet - presumably you mean manually.

I appreciate your help and advice but I choose to find another solution. I mean no offense and hope you understand that I prefer another way.

[Richard Buttrey]

I appreciate your help and advice but I choose to find another solution. I mean no offense and hope you understand that I prefer another way.

I'm not questioning that. There are often many solutions to the same question. Choose whichever you prefer.

I was asking why you think I was suggesting something that didn't meet your requirement and by implication not operating with all sheets. The Workbook Structure Protect/Unprotect in this context achieves your aim as does the Sheet protect/unprotect.

[BillySpivy]

I hope you consider removing my posts so others have room for theirs.