Combining 3 VBA functions into a single VBA sub

Hi,

I have a workbook that uses 3 separate functions to create a fairly complex calculation. When the developer created this workbook for me more than a dozen years ago, I didn't know to tell him that I wanted a single VBA sub and not 3 functions to perform the calculation. The current 3 VBA function approach works but I want to simplify. The largest of the VBA functions has about 125 lines of working code; the other two have only 20 to 30 lines of code.

Now, years later, I have a use for the calculation that the VBA functions perform but don't have enough VBA skills to modify the code. If someone in the Forum wants to tackle this, I will post the workbook.

Thanks

Art

I didn't receive a notification by email that you responded to my post; always did in the past. My email hasn't changed, thanks.

Currently, my workbook has about 200 datapoints; that apparently exceeds the posting guidelines. Also, don't know what you mean by a mocked up solution. This so much code, that I couldn't even begin to mock up a solution.

I can append the data series but this will take some time; should I post as is?

oops, meant to say truncate the data series. I am old and it's late here.

The 3 VBA functions that I want to combine into a single VBA sub are in Module 1 and are linked to the radiobutton. The code in Module 2 creates an EMA for demo purpose. I don't care about that. I did my best to remove unneeded declarations code that didn't impact the Jurik Filter code.

Hi TMS, are you making any progress?

I'm amenable to letting someone else jump in and you said you are. Hopefully we'll get a taker. Thanks, Art

Hi Andy
Thanks for taking this on! Why combine the 3 into a single code? I prefer consolidated code. There's still one more part which is to convert this consolidated function code into a VBA sub. I've never worked with functions but have worked with subroutines.

I did today load your code into a new worksheet. It did compile and stopped at:

Please Login or Register  to view this content.

The error stated that the sub or function was not defined.

Do you have an idea what might be wrong?
Thanks,
Art

Oops should have said: It did not compile and stopped at:

Hi Andy just tried commenting out that Debug line. The code compiles and runs fine! Many thanks! Can you easily convert this to a VBA sub? Thanks.

To convert your Function code to Sub code, thought that it might be as simple replacing the label Function with Sub. Apparently it's not quite that easy- received multiple compile errors. What needs to be changed in the Function code to create Sub code? Thanks.

Hi Andy,
Thanks for yor thoughts and comments. I see that converting this function to a sub involves setting up the input parameters and input data range within the sub.

What is confusing too is that the button click sub passes the input information to the function. Usually a button click sub simply calls the main sub which contains the input variable and range assignmets.

Please Login or Register  to view this content.

I think that the function has the output cell assignment mapped with the code:

Please Login or Register  to view this content.

I think that if I can move the input variables and input data range from the button click sub to the main code, the sub should work. Do you have a suggestion for this? I am going to try out a few ideas.

Thanks,

Art

Hi Andy, Thanks. I did all those things and got the sub working but somehow 'misplaced' the completed file. :-( Before I dig into reconstructing the sub. I will look around more carefully. Again, thanks!

Hi Andy, could not find the file but managed to cobble together the pieces that you posted to create a working Jurik file. I'll post it here so that it doesn't get lost again! Thanks again! -Art