Hello ,
I would open file when click selected row in listbox on form .
I write ID in texbox1 and show data in listbox . when I try to open file by clicking selected row then should match INVOICE no in column (3) in listbox with what is existed within folders and sub folders and sub - sub folders in this directory C:\Users\abgg\Desktop\archive. and when click then should open it .
the files will be types of files are pdf,excel .
thanks
Opening a file when the row of the listbox is clicked is not hard but we need to know exactly how to map the data in your listbox to the file that is to be opened.
When I click CommandButton1 the form is shown but there is no data populated. You said, "I write ID in texbox1 and show data in listbox" What is "ID"? There is nothing in the file labeled "ID". You need to give step-by-step instructions with a concrete example.
How do you determine the file name based on the invoice number in column 3? "the files will be types of files are pdf,excel" Give a specific concrete example of an invoice number and the corresponding file name. Is there only one file per invoice? What if there is both a PDF and an Excel file for the same invoice? What are the extensions for the Excel files?
I mean writing brand based on column D.There is nothing in the file labeled "ID
will match the same file name in column 3 with the same file name within directory .How do you determine the file name based on the invoice number in column 3?
yesIs there only one file per invoice?
noWhat if there is both a PDF and an Excel file for the same invoice?
See those places where I asked for concrete examples? I did not see any in your response.
in column 3 in listbox =INV-BS-1 and in directory will be excel in folder C:\Users\abgg\Desktop\archive\invoice\INV-BS-1.xlsm
in column 3 in listbox =INV-BS-2 and in directory will be excel in folder C:\Users\abgg\Desktop\archive\invoice\montly\INV-BS-2.pdf
actually I don't know if theses examples what you would.
Does this mean there are only two files total in these directories ?
Those are two different folder paths. What dictates which one to use?
Your other code is using just single letters as all the variable names, which is a very undesirable practice. The code is nearly unreadable. You have also declared only some of your variables.
I strongly recommend to everyone that they use Option Explicit and declare variables. Doing so prevents a lot of bugs and runtime errors.
Add the following code to the existing module for UserForm1. This code will work using the first path you gave. If you need to use multiple paths you need to define how to tell which path to use.
Please Login or Register to view this content.
no this is example . I have multiples files within folders and subfolders and sub-subfolders.Does this mean there are only two files total in these directories ?
thanksThis code will work using the first path you gave
the files will be in folders and subfolders and sub-subfolders within main directory.If you need to use multiple paths you need to define how to tell which path to use.
Is it so hard to understand what others have written? This is logic!
You wrote: "and when click then should open it. the files will be types of files are pdf,excel."
Right now you only have INV-BS-1 and INV-BS-2. In the real file you definitely have e.g. INV-BS-3, ..., INV-BS-10.
Imagine that I click the line with INV-BS-7. How is the code supposed to know that it should open the file ...invoice\INV-BS-7.XLSM or ...invoice\montly\INV-BS-7.PDF? Flip a coin?
if "flip a coin" then in post #7 change
toPlease Login or Register to view this content.
If there are any other subfolders besides invoice and invoice\month, I will try to provide the code right awayPlease Login or Register to view this content.
Last edited by hungt; 05-30-2025 at 04:17 PM.
[Moderating]This is overly harsh. Please be more helpful than critical.[/Moderating]Originally Posted by hungt
The code I developed (and tested) looked for an Excel file, and if it doesn't find it, it looks for a PDF file. So the code does not have to know a priori which one.How is the code supposed to know that it should open the file ...invoice\INV-BS-7.XLSM or ...invoice\montly\INV-BS-7.PDF? Flip a coin?
The harder part is traversing all subfolders.
Code in UserForm
Please Login or Register to view this content.
so how avoid this problem?The harder part is traversing all subfolders.
I don't want every time change directory when there are files in subfolders.Please Login or Register to view this content.
should deal with subfolders and sub-subfolder for main directory without change directory every time.
Please see solution in post #13
doesn't work well !Please see solution in post #13
sometimes work and sometimes doesn't work especially when change directory !
Hi abdo meghari,
try replacing "xlsm" with "xls". I didn't find any clear statement in the thread that "excel" files are just "xlsm".
m.sPlease Login or Register to view this content.
@MSDols
well done!
that fixes my problems.
many thanks for your assistance.
There are currently 1 users browsing this thread. (0 members and 1 guests)
Posting Permissions
LinkBack URL
About LinkBacks
Register To Reply
Bookmarks