vb code to return files giving too many files error message

**camcrazy08** · 08-27-2007, 03:08 PM

All,

I was wondering if someone could look at the code that I use to see if I have something in there that would create a "too many files" error message every once in a while. This error message pops up maybe once every 20 uses. In looking at the code, I see that it opens the files, but does it close them? I was hoping that someone would have some insight into this.

Basically the file returns the last row of totals on files that it opens.

Please Login or Register  to view this content.

**FrankBoston** · 08-27-2007, 03:54 PM

This program does not close the files it is opening. After a while, the internal table of open files probably fills up and you get the error message.

Please Login or Register  to view this content.

**camcrazy08** · 08-27-2007, 03:57 PM

Thank you again for the assistance.

I was confused by this because when I would get the error, I would choose end and just go and run the macro again, which would work.

This also explains why sometimes I could not move files, saying they were in use. Although, this would go away in very short time.

Also, in this next case, would this close fn go before loop or before End If? I would guess End If...

Please Login or Register  to view this content.

**FrankBoston** · 08-27-2007, 04:10 PM

I suggest putting it just after the Loop statement.
The usual approach is to close the file as soon as you are done reading from it.

In that spirit, my last advice was not elegant. That "Close fn" could also be put just after the Loop statement that ends the line-reading loop.

It does work where I previously said to put it, after the assignments, but it is neater and easier to find if it goes just after the reading loop.