Short circuiting logical expressions?

[jennyc2]

Hi everyone!

I have a problem with a part of my program. I would like to execute the second expression in this statement:

If AndAlso(ActiveCell.Offset(i - 1, 2) <> "", DateValue(ActiveCell.Offset (i - 1, 2)) < DateValue(Today)) Then
ActiveCell.Offset(i - 1, -7).Value = "4"

ONLY if the first expression is not true. Since excel seems to execute both statements in an AND command, I wrote my own AndAlso function:

Public Function AndAlso(expr1 As Boolean, expr2 As Boolean) As Boolean
If expr1 Then
If expr2 Then
AndAlso = True
Else
AndAlso = False
End If
Else
AndAlso = False
End If
End Function

(Sorry for the bad indent!) It doesn't look so nice, so I am figuring that there must be better ways. Also I still get an error message from the DateValue-execution when the cell is empty. Anyone has any ideas?

[arthurbr]

Hi, please take a moment to read forum rules about wrapping your code with tags.

[jennyc2]

Oh right, sorry, here is a new try to post the code:

Please Login or Register  to view this content.

Please Login or Register  to view this content.

[arthurbr]

Ok, thx for adapting. You didn't have to make a new post, just edit your original one, and adapt.

[shg]

Your function receives two logical arguments. The way they got from being expressions to being Booleans is via evaluation. If one of them evaluates to an error, AndAlso never executes.

Skip AndAlso, but use the same construct as you did in AndAlso.

And also (), instead of

Please Login or Register  to view this content.

use

Please Login or Register  to view this content.

[jennyc2]

Thanks for your reply! I removed the function but now there is a different error due to the nested ifs. See, I have three columns (and multiple rows) of information to look through and the cells can be either empty or contain a date, so I have to check each cell first and then calculate if the date has passed or not. If it has passed, then it should change to the next row.

Although the sub continues to check the other columns too and replaces the result with the number of the last non-empty cell. Since an "Exit For" could not solve - what can?

Please Login or Register  to view this content.

Thanks in advance for all help possible! This is really tricky for me!

[shg]

I can't tell what you're trying to do. Maybe this:

Please Login or Register  to view this content.

Also, if the cells in question contain actual dates (as opposed to text that looks like dates), I'd change the coode to look more like this:

Please Login or Register  to view this content.