Combining two macros results in error message

Hello all,

Note: It should also be noted that, when "splitting" the macros below up into two different macros, they work, but then I have to play 2 macros when I only want to play one.


Just when I thought I was getting this macro stuff, I've come back to reality. I tried to combine these 2 macros together (taking out 1 "sub" and 1 "end sub") and when doing so, I got the error message

"duplicate declaration in current scope"

I thought about removing some "Dim" lines, but realized that the Dims say different things. For example in macro 1, it says "Dim Rng As Range" and in macro 2, it says "Dim Cust As Range".

Don't I need both? Do I put in an "exit sub"?

thanks much

Please Login or Register  to view this content.

I can't spend long looking at this I'm afraid (ie there may be other issues) but...

You can only Dim a given variable once in any given routine (you may latterly ReDim an Array), if you look you will find you will be (if combining the two macros) declaring Rng variable twice thereby leading to a Dupe Declaration.
It is best to put all of your declarations prior to any code, this is a good step towards avoiding duplication etc...

There's no way that I can say "when done with macro 1, go to macro 2, when done with macro 2, go to macro 3, etc"?

Please Login or Register  to view this content.

No, each routine is entirely separate from the other(s) - none of your variables are seemingly "global" so there shouldn't be any issues as I see it.
http://www.ozgrid.com/VBA/variable-scope-lifetime.htm

Are your 7 different macros called Report2_Part1 etc.... ?
It sounds as though you have used the module names rather than the names of the sub routines (or you have given your modules the same name as the routine contained within)

Correct, not a good idea... maybe prefix each Module with Mod_ ie Mod_RoutineName

I think you misunderstood ... prefix the Module name with Mod_RoutineName, leave the routine as RoutineName... this way the two are named separately (you use Call RoutineName) but in VBE Project Explorer you can easily identify the module containing the routine of interest by it's name (now just prefixed with mod_)