You need to put your code in code tags, or you'll be in more trouble.
As this is an assignment I think it would be wrong for me to just give you the answer, but I've put a few comments in your code...
Private Sub CommandButton1_Click()
Dim Arr(3) As Integer
Arr(0) = Mid(TextBox1, 1, 1)
Arr(1) = Mid(TextBox1, 2, 1)
Arr(2) = Mid(TextBox1, 3, 1)
Arr(3) = Mid(TextBox1, 4, 1) 'This whole section could be done in a loop
For Arr = 0 To 3
Arr (0) + 7 'This line doesn't do anything because it's not assigning the value to anywere, you also need to look at the Mod function (as per the requirements)
Next
Loop 'Which loop?
TextBox2.value = Arr(2) & Arr(3) & Arr(0) & Arr(1)
Bookmarks