select case compile error

[karl1985]

hey all,


i've got the following code that used to work until I changed something and now I can't work out why it doesn't work.

Please Login or Register  to view this content.

Can anyone work out why I am getting the
"Case Without Select Case" Error

Thanks in advance.

[Andy Pope]

If you indent your code you will see that the actual problem is a missing End If rather than Case, even if that is what the compiler reported.

Please Login or Register  to view this content.

Also some of the code does not make sense as it will never be executed due to a proceeding Exit Sub.

[karl1985]

Thanks for your help, before I saw your answer I actually did what you said. I started a new document and moved each part of the code over to the new sheet constantly checking for errors and in the meatime cleaning up my code with the use of indenting.

I ended up witht eh following which works a treat

Please Login or Register  to view this content.

I'm sure the code could still be made more efficient, but i've changed the ranges to named ranges and indented the code so that its much easier to read and follow.

I did try having subroutines for each case with the "call macro" function but that didn'tseem to work so I am left with the above.


Thank you for all your help, yet another positive response from a great bunch of people.

Karl

[TMS]

You're welcome. Thanks for the feedback.

Whats with ...

Please Login or Register  to view this content.

Where are you trying to get to?

And do you need to select cells at all?


Regards

[karl1985]

i'm trying to get to column B of the active row of which the value of that cell needs to = vNOMISdis


something like:

vNOMISdis = DISCELL.Offset("current row, column B) .value


I just don't know how to put that piece of code together and got lazy, found a solution and left it.

[TMS]

Try changing:

Please Login or Register  to view this content.

To:

Please Login or Register  to view this content.

And remove all the positioning statements.


Regards

[karl1985]

Billiant, proberbly the simpliest part of my code.

a great tidy up for my code.

Thanks again

Very Happy.