If Statement Erroring at Runtime

[Mordred]

Hi all,

I am attempting to create what my user is calling an escalator. If the escalator option is selected on my user form, the user can tweak the weight percentages. The sum of these weights must = 1 (see picture[I know you all love pictures]). I have the following code that is supposed to sum the weights and let the user know if they are not equaling 1. The problem I am having, and I must say that it is not all the time, is; if the user's weights = 1, the error message comes up saying that the escalator should = 1, the current sum of values =1. ???? If the sum =1 then everything SHOULD be okay. The code:

Please Login or Register  to view this content.

EscSum, when stepping through it equals 1 but

Please Login or Register  to view this content.

does not compute right for some reason. Hopefully someone can see in this little section of code how this is not working out right for me. The file can be located here. Like I have previously stated, this problem does not occur all of the time which confuses me even more.

[Leith Ross]

Hello Mordred,

I don't see any variable declarations. What variable type is EscSum?

[Mordred]

Sorry Leith, I didn't want to bombard the forum with all the code. EscSum is a double.

[Leith Ross]

Hello Mordred,

In that case, it is probably a rounding problem. Select a variable type that matches the maximum number of decimal places you need. Converting a Double down to another smaller number type like Single, or Long will still be rounded. Another method would be Fix the value to a set number of digits.

[Mordred]

Another method would be Fix the value to a set number of digits.

Hi Leith, I'm not sure about how to do that (or what you mean).

[Andrew-R]

Another possibility - I don't see anywhere in your code where you're initialising the value of EscSum, shouldn't you have an EscSum=0 in there before you go into your EscCntr loop?

[Leith Ross]

Hello Morderd,

Here is an example of fixing the decimal places.

Please Login or Register  to view this content.

[Mordred]

Hi Andrew, I have specifically declared EscSum to = 0 but it did not seem to make a difference. By default though, it is 0.

[Mordred]

Thanks Leith, I'm sure your advice will work once I figure out how to work it into what I already have. I'll let you know how it goes.

[Leith Ross]

Hello Mordred,

If you get stuck, you know where to find to me.

[vlady]

hello
why is it not inside for next loop

If EscSum<>
endif

[Mordred]

Hi vlady,

Please Login or Register  to view this content.

is not in the loop because it checks the total sum of Esc values. That sum can't be determined until after the loop.

[Mordred]

@Leith, I can't figure out how to apply your fix to my problem. I have tried

Please Login or Register  to view this content.

but that seems to round the EscSum2 value down to 0 after each iteration of the for loop.

[Andy Pope]

FIX will return the integer portion of a number. So if the value is less than 1 you will get zero.

maybe try

Please Login or Register  to view this content.

Or use the FIX here

Please Login or Register  to view this content.

[Mordred]

Thanks Andy, so far

Please Login or Register  to view this content.

is working properly. Thanks for your assistance!

[snb]

BTW

Please Login or Register  to view this content.

[Mordred]

Thanks everyone, I'm going with snb's solution, it works perfectly for my purposes.