Problem with deleting duplicates

[Sean Thomas]

Hi,
I have been trying to delete rows based on 4 columns criteria.
Unfortunately i cannot use the auto filter method without upsetting the order of the data.
I am pulling data from a number of workbooks each week. Then i need to deal with any duplicated rows.
Columns to check are
E name ie Sean Thomas
J Claim number ie 00884565 or 006734561/1 or 12345672 or similar
K Registration ie ABC123Z
U Cost ie £1234.50

range of data A7:U & lastrow

Checking the last row first to 7
if E ,J,K are the same then check U (cost)
if its the same as one above then delete it
if its more or less than the one above, then delete the one above.

I have tried deleting row based on criteria but this leaves a few duplicates still
if i use the below code and change colour only, it works, but when i run the delete code it doesnt.

the only way it seems to work is when i run the same code in concession.

I cant for the life of me see what i am doing wrong.
Sorry i cant upload data due to confidential data.

any suggestions please?

Please Login or Register  to view this content.

[nilem]

Look at these lines

Please Login or Register  to view this content.

Sheets("Engineers Savings") and Sheet1 the same?
try so

Please Login or Register  to view this content.

And also declare variables as

Please Login or Register  to view this content.

[Sean Thomas]

hi, thanks for the advise.
found the error , needed to add an exit for when deleting the current row.

Now this is the weird bit i cannot understand!
I was originally running the code from within a userform (Progress indicator)
everything else works fine, however when i run this code within the userform module it doesnt delete all duplicates.
However if i run the code from a standard module on the same data it works fine.
if i call the same procedure in the std module from within the userform it doesnt work properly.
if i call it directly after unloading userform it works fine.

any ideas?

Please Login or Register  to view this content.

Unable to load file as too large, cant reduce the size as mainly due to uerform which holds the code.

[Sean Thomas]

For some reason my last post did not appear on latest threads.
lets try again.

[Sean Thomas]

Added file just in case. Managed to delete a load of stuff to reduce size

[Sean Thomas]

I seem to have resolved the issue.
I have used a progress indicator and have the code to import the other workbook data in that module.
I then unload that form and open another progress indicator that hold the code to delete duplicate rows, blank rows and format the font etc.
Really strange, i havent actually changed any of the code, only split it into 2 forms and it works.

Is there only a certain amount of code you can put into a userform module?

[AB33]

This may not helpful, or relevant, but I though you want to shift A-U, not delete the entire row which your code is right now doing