Is it possible to assign a userform NAME to a variable and reference the form?

[TC1980]

Hi,

I've drawn a bit of a blank with this one.

I would like to assign a form username to a variable that I can then reference from another module. The reason for this is that I have a few userforms that are slightly different in terms of content and layout but share many similarities in function. To keep everythign a bit neater i'd like to hold most of the 'doing' code within a module and then call it as required from the userform code.

I understand that I can .show a userform via this method, but not sure if it's possible to reference it for other purposes - e.g. populating a combobox list.

The code setup I have at present:

Userform (TransForm1):

Please Login or Register  to view this content.

Module1:

Please Login or Register  to view this content.

This in itself doesn't trigger any runtime errors (though it does trigger the userform initialise event again when it reaches 'Set CurrForm', I have a bit of code to work around that) but when it comes to the Case Select statement it doesn't register any of the cases as true - leading me to suspect that it isn't carrying over the Userform name properly. This code ran fine when the POSType sub was within the userform module.

So any ideas? Can it be done? Or do I need to just copy and paste the code and live with it being messy?

[JosephP]

replace

Please Login or Register  to view this content.

by

Please Login or Register  to view this content.

note this is not really good design in my opinion. you ought to either pass the control you want filled as an argument to the routine or change the routine to a function that returns the array you want assigned to the list

[TC1980]

That works great thanks JP and doesn't trigger the initialise even either.

Why do you feel this is not good design? Not trying to be difficult, just want to understand.
How would I pass the control (guessing that would also include the form it resides in) and yet also let that control to be +1'd? I need to check the case of the first combobox and then update the second, applying to any one of ten 'pairs' of comboxes, across multiple userforms?

[JosephP]

it's not good design because

• you are assuming the names of the controls in the routines which is unnecessary and awkward
• you're using public variables which should be avoided when possible-and it's certainly possible here
• you mention slight differences in layout and content which makes me suspect that one form with some dynamic content might be a better option than multiple similar forms

it also sounds as though using a class (or a few) to handle the linked controls might be an option

you could alter your routine to take two controls as arguments then pass both from each calling form

Please Login or Register  to view this content.

and call with

Please Login or Register  to view this content.

[TC1980]

Thanks again JP. Works perfectly as I didn't doubt.

Okay I think I understand this. So I should pass control names within the brackets to the called sub as and when required rather than declaring them publicly.
I have a fair few public variables within my code as that was the only way I knew how to share variable data between different subroutines. I'm guessing I could get rid of a lot of these using a similar method to that above. I will review my code and see what tidying I can do. If I get stuck then I'll do some more searching on passing arguments.

Regarding point three - you are probably right on that count - but I'm fairly new to this and there's only so much info I can take in and make stick at one time. I'll leave dynamic content creation for another day.

Thanks again, TC