+ Reply to Thread
Results 1 to 15 of 15

Extracting data from two sheets in external workbooks - 2nd sheet won't paste

  1. #1
    Registered User
    Join Date
    10-11-2013
    Location
    falkirk
    MS-Off Ver
    Excel 2007
    Posts
    69

    Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    I have been extracting data from a number of workbooks and in this case I need B4:B34 from sheets 4 and 6 on external workbooks.
    What I need is the filename in col A and the extracted data in column B, so 2 lots of 32 cells. First sheet would then occupy A1:B64. Next sheet would take A65:B128 and so on.
    This code works fine but only extracts from sheet 4 on each file.
    Can anyone see the flaw(S)? Thanks.

    Please Login or Register  to view this content.

  2. #2
    Forum Guru HaHoBe's Avatar
    Join Date
    02-19-2005
    Location
    Hamburg, Germany
    MS-Off Ver
    work: 2016 on Win10 (notebook), private: 2019 on Win10 (desktop), 2019 on Win11 (notebook)
    Posts
    8,197

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    Hi, ids,

    First sheet would then occupy A1:B64. Next sheet would take A65:B128
    In your code to assign the very same destiantion range to both ranges instead of setting the second after the paste or including the offset for the first range with
    Please Login or Register  to view this content.
    And if you copy just
    Please Login or Register  to view this content.
    Iīm missing the part like
    Please Login or Register  to view this content.
    either before or after that. Again: make sure youīre not assigning the same ranges to the destination ranges.

    Ciao,
    Holger
    Use Code-Tags for showing your code: [code] Your Code here [/code]
    Please mark your question Solved if there has been offered a solution that works fine for you

  3. #3
    Registered User
    Join Date
    10-11-2013
    Location
    falkirk
    MS-Off Ver
    Excel 2007
    Posts
    69

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    Thanks for coming back to me there.
    I have changed the destination ranges as you suggest.
    Please Login or Register  to view this content.
    Also, adjusted the 2nd destination range.
    This is good because I now get all the info that I need, but the filename only appears in the first 30 rows.
    Having said that and seen the results, I am now think that it would be better to have rows that do not contain any data supressed. I think this means a rethink of all the code?

  4. #4
    Registered User
    Join Date
    10-11-2013
    Location
    falkirk
    MS-Off Ver
    Excel 2007
    Posts
    69

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    Please ignore last post - back on track again.
    Stepping through the program using F8, Filename 1 pastes to A2-A31 then sheet 4 data is pasted into B2-B31, then sheet 6 is pasted into B32-B61. Filename 2 pastes to A32-A61 and the next sheet 4 overwrites the previous data.
    Need Filename 1 A2-A61, sheet 4 cells to B2-B31, sheet 6 cells to B32-B61, then
    Filename 2 A62-A121, sheet 4 cells to B62-B91, sheet 6 cells to B92-B121 etc., etc.
    Cannot see how to increase the offset in column A with there being a knock on effect.
    Can anyone see how this could be modified?

    Current code:
    Please Login or Register  to view this content.

  5. #5
    Forum Guru HaHoBe's Avatar
    Join Date
    02-19-2005
    Location
    Hamburg, Germany
    MS-Off Ver
    work: 2016 on Win10 (notebook), private: 2019 on Win10 (desktop), 2019 on Win11 (notebook)
    Posts
    8,197

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    Hi, ids,

    Please Login or Register  to view this content.
    are the least of the lines which would need to be altered (no sheet6 to be copied when I glimpsed through the code).

    Ciao,
    Holger

  6. #6
    Forum Guru HaHoBe's Avatar
    Join Date
    02-19-2005
    Location
    Hamburg, Germany
    MS-Off Ver
    work: 2016 on Win10 (notebook), private: 2019 on Win10 (desktop), 2019 on Win11 (notebook)
    Posts
    8,197

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    Hi, ids,

    regarding different Columns you could use code like
    Please Login or Register  to view this content.
    Regarding the rows where to copy you should comment out
    Please Login or Register  to view this content.
    in order not to go down the rows.

    Ciao,
    Holger

  7. #7
    Registered User
    Join Date
    10-11-2013
    Location
    falkirk
    MS-Off Ver
    Excel 2007
    Posts
    69

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    Quote Originally Posted by HaHoBe View Post
    Hi, ids,

    Please Login or Register  to view this content.
    are the least of the lines which would need to be altered (no sheet6 to be copied when I glimpsed through the code).

    Ciao,
    Holger
    Thanks Holger.
    The problem I think is that I am trying to use 1 variable (sourcerange) to do two different things
    Here for pasting filename:
    Please Login or Register  to view this content.
    and here for pasting sheet 4 & sheet 6
    Please Login or Register  to view this content.
    The sheet 6 paste does occur here
    Please Login or Register  to view this content.

  8. #8
    Forum Guru HaHoBe's Avatar
    Join Date
    02-19-2005
    Location
    Hamburg, Germany
    MS-Off Ver
    work: 2016 on Win10 (notebook), private: 2019 on Win10 (desktop), 2019 on Win11 (notebook)
    Posts
    8,197

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    Hi, ids,

    The problem I think is that I am trying to use 1 variable (sourcerange) to do two different things
    To be honest: I think you donīt really understand what the code is doing and maybe choose it because you believe it to be fitting for your problem but the code may be simplified due to your requests. Maybe itīs a good idea to put the cursor isnoide the procedure and use F8 to single step through the code in order to view what the code is supposed to do.

    The problem about the filename is that you either have to do it every other column in order to get the proper name for each set of data. Or you put it above the data (like it is in my version). And I donīt believe it to be very efficient to create an array with the file names and only after that get on opening the files and work on them.

    Please Login or Register  to view this content.
    Ciao,
    Holger

  9. #9
    Registered User
    Join Date
    10-11-2013
    Location
    falkirk
    MS-Off Ver
    Excel 2007
    Posts
    69

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    Hi Holger, thanks for your continued assistance. I think your assumptions are quite correct
    I am stepping through your new code with F8 and the first filename is written into A2. This is then overwritten by the sheet 6 data. Sheet 4 data is then written into A32.
    Then the 2nd filename is written into A2, overwriting the first cell of sheet 6 data. Then sheet 4(2nd file) data overwrites the sheet 4 (1st file) data. This cycle is ongoing with further files.
    Getting close but all data is being overwritten onto the same footprint at A2 and A32 start locations.
    Last edited by ids; 01-09-2014 at 07:47 AM. Reason: wrong file number

  10. #10
    Forum Guru HaHoBe's Avatar
    Join Date
    02-19-2005
    Location
    Hamburg, Germany
    MS-Off Ver
    work: 2016 on Win10 (notebook), private: 2019 on Win10 (desktop), 2019 on Win11 (notebook)
    Posts
    8,197

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    Hi, ids,

    you would need to correct the number where to start (I used 2 there - it should have been row 1 instead). So the data should get aligned under teh filename .

    Ciao,
    Holger

  11. #11
    Registered User
    Join Date
    10-11-2013
    Location
    falkirk
    MS-Off Ver
    Excel 2007
    Posts
    69

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    OK thanks, I am getting data in adjacent columns for each external sheet now.
    For my application, I need to reformat these sections vertically into the first two columns, "filename" & "Data" respectively.

  12. #12
    Forum Guru Izandol's Avatar
    Join Date
    03-29-2012
    Location
    *
    MS-Off Ver
    Excel 20(03|10|13)
    Posts
    2,581

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    You may try:
    Please Login or Register  to view this content.
    • Please remember to mark threads Solved with Thread Tools link at top of page.
    • Please use code tags when posting code: [code]Place your code here[/code]
    • Please read Forum Rules

  13. #13
    Registered User
    Join Date
    10-11-2013
    Location
    falkirk
    MS-Off Ver
    Excel 2007
    Posts
    69

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    Hi Izandol, I will try this now. Thanks

  14. #14
    Registered User
    Join Date
    10-11-2013
    Location
    falkirk
    MS-Off Ver
    Excel 2007
    Posts
    69

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    Perfect! Works exactly as I need - thanks Izandol

  15. #15
    Forum Guru Izandol's Avatar
    Join Date
    03-29-2012
    Location
    *
    MS-Off Ver
    Excel 20(03|10|13)
    Posts
    2,581

    Re: Extracting data from two sheets in external workbooks - 2nd sheet won't paste

    You are welcome.

+ Reply to Thread

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. Replies: 0
    Last Post: 07-29-2013, 03:00 AM
  2. Extracting and combining data from specific sheet from multiple workbooks
    By aggies2010 in forum Excel Programming / VBA / Macros
    Replies: 4
    Last Post: 02-19-2013, 03:39 PM
  3. Copy Paste Data across Workbooks with multiple sheets & Referencing.
    By v999 in forum Excel Programming / VBA / Macros
    Replies: 2
    Last Post: 10-30-2012, 09:16 AM
  4. Replies: 5
    Last Post: 02-06-2012, 09:45 AM
  5. Replies: 7
    Last Post: 01-05-2009, 02:08 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Search Engine Friendly URLs by vBSEO 3.6.0 RC 1