Worksheet_Change question

[wrightyrx7]

Hi all,

I am writing the below code, but when i step through it.

Its goes to the below line

Range("B" & ThisRow).Formula

then "END IF"

Then it goes back to the top of the code, then instead of going to the line above it goes to this

Range("C" & ThisRow).Formula

Its more of a loop. And its causing me problems when trying to "ClearContents"

Please help

Private Sub Worksheet_Change(ByVal Target As Excel.Range)
Dim ThisRow As Long
Dim dRng As Range
    ThisRow = Target.Row
    If Target.Column = 1 Then
        If Target.Value <> "" Then
            Range("B" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",'All Staff (Names)'!A:C,3,FALSE)"
            Range("C" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",'All Staff (Names)'!A:C,2,FALSE)"
            Range("E" & ThisRow).Formula = "=DATEDIF(VLOOKUP(A" & ThisRow & ",DETAILS!A:D,4,FALSE),""14/02/2014"",""Y"")"
            Range("F" & ThisRow).Formula = "=DATEDIF(VLOOKUP(A" & ThisRow & ",Salary!A:D,4,FALSE),""14/02/2014"",""Y"")"
            Range("G" & ThisRow).Formula = "=VLOOKUP(VLOOKUP(A" & ThisRow & ",DETAILS!A:I,8,FALSE),Division!B:C,2,FALSE)"
            Range("H" & ThisRow).Formula = "=VLOOKUP(VLOOKUP(A" & ThisRow & ",DETAILS!A:I,9,FALSE),Department!B:C,2,FALSE)"
            Range("I" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",DETAILS!A:G,7,FALSE)"
            Range("J" & ThisRow).Formula = "=VLOOKUP(VLOOKUP(A" & ThisRow & ",DETAILS!A:E,5,FALSE),'All Staff (Names)'!A:D,4,FALSE)"
            Range("R" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",'Active SUP'!A:J,10,FALSE)"
            Range("S" & ThisRow).Formula = "=IF(AND(R" & ThisRow & "=""LGPS"",E" & ThisRow & ">=55),""Y"",""N"")"
            Range("AA" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",Salary!A:C,2,FALSE)"
            Range("AB" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",Salary!A:C,3,FALSE)"
            'Range("AC" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",Salary!A:C,3,FALSE)"
            Range("AD" & ThisRow).Formula = "=AA" & ThisRow & "*3"
            Range("AE" & ThisRow).Formula = "=AA" & ThisRow & "*2"
            Range("AF" & ThisRow).Formula = "=AC" & ThisRow & "+AD" & ThisRow & "+AE" & ThisRow
            Range("AG" & ThisRow).Formula = "=IF(S" & ThisRow & "=""Y"",AF" & ThisRow & "-T" & ThisRow & ",""NO CAP COST"")"
            Range("AH" & ThisRow).Formula = "=(AD" & ThisRow & "*22%)+AE" & ThisRow & "+AC" & ThisRow
            Range("AI" & ThisRow).Formula = "=IF(S" & ThisRow & "=""Y"",AH" & ThisRow & "+T" & ThisRow & ",""NO CAP COST"")"
            Range("AJ" & ThisRow).Formula = "=AB" & ThisRow & "*22%"
            Range("AK" & ThisRow).Formula = "=AB" & ThisRow & "+AJ" & ThisRow & ""
        Else
            Rows(ThisRow).ClearContents
            Exit Sub
        End If
    End If
End Sub

[Norie]

That line of code changes the sheet, so the worksheet change event is called.

Try disabling events,

Application.EnableEvents = False

but don't forget to enable them again.

Application.EnableEvents = True

[Norie]

http://www.mrexcel.com/forum/excel-q...-question.html


Your post does not comply with Rule 8 of our Forum RULES. Do not crosspost your question on multiple forums without including links here to the other threads on other forums.

Cross-posting is when you post the same question in other forums on the web. The last thing you want to do is waste people's time working on an issue you have already resolved elsewhere. We prefer that you not cross-post at all, but if you do (and it's unlikely to go unnoticed), you MUST provide a link (copy the url from the address bar in your browser) to the cross-post.

Expect cross-posted questions without a link to be closed and a message will be posted by the moderator explaining why. We are here to help so help us to help you!

Read this to understand why we ask you to do this, and then please edit your first post to include links to any and all cross-posts in any other forums (not just this site).

[TMS]

For testing purposes, please provide a sample workbook in future. To test your code, it was necessary to create a new workbook and then create and name 7 worksheets.

Also, if you make changes to a sheet within a Change event handler, you need to disable event handling.

Private Sub Worksheet_Change(ByVal Target As Excel.Range)
Dim ThisRow As Long
Dim dRng As Range
ThisRow = Target.Row
If Target.Column = 1 Then
    If Target.Value <> "" Then
        Application.EnableEvents = False
        Range("B" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",'All Staff (Names)'!A:C,3,FALSE)"
        Range("C" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",'All Staff (Names)'!A:C,2,FALSE)"
        Range("E" & ThisRow).Formula = "=DATEDIF(VLOOKUP(A" & ThisRow & ",DETAILS!A:D,4,FALSE),""14/02/2014"",""Y"")"
        Range("F" & ThisRow).Formula = "=DATEDIF(VLOOKUP(A" & ThisRow & ",Salary!A:D,4,FALSE),""14/02/2014"",""Y"")"
        Range("G" & ThisRow).Formula = "=VLOOKUP(VLOOKUP(A" & ThisRow & ",DETAILS!A:I,8,FALSE),Division!B:C,2,FALSE)"
        Range("H" & ThisRow).Formula = "=VLOOKUP(VLOOKUP(A" & ThisRow & ",DETAILS!A:I,9,FALSE),Department!B:C,2,FALSE)"
        Range("I" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",DETAILS!A:G,7,FALSE)"
        Range("J" & ThisRow).Formula = "=VLOOKUP(VLOOKUP(A" & ThisRow & ",DETAILS!A:E,5,FALSE),'All Staff (Names)'!A:D,4,FALSE)"
        Range("R" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",'Active SUP'!A:J,10,FALSE)"
        Range("S" & ThisRow).Formula = "=IF(AND(R" & ThisRow & "=""LGPS"",E" & ThisRow & ">=55),""Y"",""N"")"
        Range("AA" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",Salary!A:C,2,FALSE)"
        Range("AB" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",Salary!A:C,3,FALSE)"
        'Range("AC" & ThisRow).Formula = "=VLOOKUP(A" & ThisRow & ",Salary!A:C,3,FALSE)"
        Range("AD" & ThisRow).Formula = "=AA" & ThisRow & "*3"
        Range("AE" & ThisRow).Formula = "=AA" & ThisRow & "*2"
        Range("AF" & ThisRow).Formula = "=AC" & ThisRow & "+AD" & ThisRow & "+AE" & ThisRow
        Range("AG" & ThisRow).Formula = "=IF(S" & ThisRow & "=""Y"",AF" & ThisRow & "-T" & ThisRow & ",""NO CAP COST"")"
        Range("AH" & ThisRow).Formula = "=(AD" & ThisRow & "*22%)+AE" & ThisRow & "+AC" & ThisRow
        Range("AI" & ThisRow).Formula = "=IF(S" & ThisRow & "=""Y"",AH" & ThisRow & "+T" & ThisRow & ",""NO CAP COST"")"
        Range("AJ" & ThisRow).Formula = "=AB" & ThisRow & "*22%"
        Range("AK" & ThisRow).Formula = "=AB" & ThisRow & "+AJ" & ThisRow & ""
        Application.EnableEvents = True
        Exit Sub
    Else
        Application.EnableEvents = False
        Rows(ThisRow).ClearContents
        Application.EnableEvents = True
        Exit Sub
    End If
End If
End Sub

Regards, TMS

[TMS]

@Norie: sorry, busy creating the workbook to test the code.

@wrightyrx7: if you change one cell, its address is not going to be "$A$3:$A$65536". That's why the code was failing, unless you were selecting and deleting everything from row 3 down.


Regards, TMS

[wrightyrx7]

Thank you so so much

[TMS]

You're welcome.



If you are satisfied with the solution(s) provided, please mark your thread as Solved.


New quick method:
Select Thread Tools-> Mark thread as Solved. To undo, select Thread Tools-> Mark thread as Unsolved.

Or you can use this way:

How to mark a thread Solved
Go to the first post
Click edit
Click Go Advanced
Just below the word Title you will see a dropdown with the word No prefix.
Change to Solved
Click Save


You may also want to consider thanking those people who helped you by clicking on the little star at the bottom left of their reply to your question.