condense VBA

[dantray02]

Hi, is there a way of making the following more efficient:

Basically, I am exporting a selection of pages from a workbook. THe selection is determined by the following

Please Login or Register  to view this content.

The value in B47 will either be a 0,1,2

2 - selects minimum range, plus two additional sheets
1 - selects minimum range, plus one additional sheet
0 - selects minimum range only.

the code is:

Please Login or Register  to view this content.

after which point a pdf is generated.

as always thank you in advance.

[Kaper]

You can start with

Please Login or Register  to view this content.

[TMS]

Maybe:

Please Login or Register  to view this content.

Regards, TMS

[Kaper]

Then next step could be:

Please Login or Register  to view this content.

[TMS]

@Kaper: that's neat. Do you need a Case Else for the "0" option?

And the double post is the forum, not you. Report the post to get it removed as a" forum induced double post"

Regards, TMS

[Kaper]

Hi,

Thanks for advice with double post.

As for case 0 (or case else) - I do not think is needed.
initial value of sheetsstring has already all needed sheet names.
Something has to be added to this string only in case 1 or 2.

[jindon]

I would write like this.

Please Login or Register  to view this content.

[TMS]

So, if x=2, you would reduce the upper bound by 2 ... . Feels wrong but I might be missing something.

I like the concept but maybe it should be -(2-x)

Regards, TMS

[jindon]

Ahhh, it was other way around... thanks.

Perhaps

Please Login or Register  to view this content.

[dantray02]

Hi, sorry for the delay - I have been away for a week.

Can I please ask - if I needed to include an additional worksheet at the end of

Please Login or Register  to view this content.

based on the same criteria how would I go about that?

I have tried

Please Login or Register  to view this content.

but this does not work.

thanks.
dan.

[TMS]

Well, the Director sheets are the optional ones, so they have to stay at the end.

Stick it in the middle somewhere before those Director items. I guess where depends on the sequence you want them printed.

Regards, TMS

[dantray02]

Hi,

The additional pages would also be optional. So if either director has a tax projection then i would also want to show the calculation at the end

thanks.

[TMS]

Then you need to look at your OP and adapt the code to reflect another variation.

The value in B47 will either be a 0,1,2

2 - selects minimum range, plus two additional sheets
1 - selects minimum range, plus one additional sheet
0 - selects minimum range only.

Regards, TMS

[snb]

Please Login or Register  to view this content.