trying to change a txtbx in module

I have a project with many forms and textboxes. I am trying to create a module that will add a "." (Chr45) in the value.

this is the code on the userform. the textbox name changes throughout the project

Private Sub TextBox4_Exit(ByVal Cancel As msforms.ReturnBoolean)

Run TxtBx_Change

end sub

this is what i have in the module. I suspect it has to do with knowing the actual name of the textbox?
the code below is not working, could anyone help?

Private Sub TxtBx_Change()
Dim CtlTxt As TextBox
Dim Str1 As String
Dim Str2 As String

Str1 = Mid(CtlTxt.Value, 1, 2)
Str2 = Mid(CtlTxt.Value, 3, 4)

If CtlTxt.TextLength = 4 Then
    CtlTxt.Value = Str1 & Chr(45) & Str2
End If

End Sub

it is a basic code i am just starting to work with. I will be expanding the code as soon as i figure out this simple task

Hi

One option is to pass in a parameter to your sub which tells the TxtBx_Change routine which textbox to run code against - this will have the added benefit of making the routine reusable for each textbox:

Private Sub TextBox4_Exit(ByVal Cancel As msforms.ReturnBoolean)

TxtBx_Change Me.TextBox4   'dont use Run

end sub

Private Sub TxtBx_Change(ctrl As Control)
'Dim CtlTxt As TextBox === now unnecessary
Dim Str1 As String
Dim Str2 As String

Str1 = Mid(Ctrl.Value, 1, 2)
Str2 = Mid(Ctrl.Value, 3, 4)

If Ctrl.TextLength = 4 Then
    Ctrl.Value = Str1 & Chr(45) & Str2
End If

End Sub

Richard

Originally Posted by Zygoid

i am getting an error on that line in the event

"sub or function not defined"

Where have you defined the TxtBx_Change sub? If it is in a separate module to the Userform then you need to remove the Private keyword from the start of the sub name.

Originally Posted by Zygoid

the userform and module are in the same project. is that what you mean?

If they are in separate modules (and it sounds like they are) then you need to remove the Private keyword from the Sub name (just of TxtBx_Change, not the TextBox4_Exit routine).

Can you post the full code you are using. Also, if in a standard module, can you change the sub declaration to:

Sub TxtBx_Change(ctrl As MSForms.Control)

Hello Zygoid,

Place this macro in a standard module and then add calls to each of the TextBox_Exit events.

Main Macro

Sub CheckDecimal(ByRef TxtBox As MSForms.TextBox)

  Num = TxtBox.Value
  
  If Len(Num) = 4 Then
    TxtBox.Value = Left(Num, 2) & "." & Right(Num, 2)
  End If
  
End Sub

TextBox Exit Code

Private Sub TextBox1_Exit(ByVal Cancel As MSForms.ReturnBoolean)
    CheckDecimal ActiveControl
End Sub

Sincerely,
Leith Ross

You could alternatively just hook into another event to check all the text box values at the same time? Eg if the user subsequently needs to hit a command button to submit the form's contents then you could use the button's click event to execute a loop which runs thru all the textboxes on the userform and checks & amends the values as appropriate.

Please could you post the current sub header of the procedure TxtBx_Change.

Richard