code consolidation

What is your concern? The code is fairly compact and efficient. Trying to make it smaller would probably make is less readable but no more efficient.

I would make one change but you wouldn't notice any practical difference in how fast it runs. Using a function to return a static string is terribly inefficient. Just move the string up into the calling function and delete function keywords_bad.

Please Login or Register  to view this content.

Also I note that it is ironic that you are responding to an automated message to say that you don't respond to automated messages. Why are you even sending a response?

Originally Posted by omahaNative_1023

the constant takes memory and sits unused when the session is running.

This is not correct. The constant will use memory only when senderIsBad is called and loaded onto the stack. It does not use heap memory.

Look at the big picture. You are worried about memory performance of subs and functions that take milliseconds to run and take up negligible memory. The string takes up 352 bytes. Nobody worries about 352 bytes when system memory is measured in GB.

Second, how frequently do you receive email? Unless you are getting hundreds of emails a minute, you will not see any advantage to further optimization of this code. What performance problem are you trying to solve?

You are searching for each word of the subject to occur anywhere in a string. It is not matching "on", it is matching "a". The word "a" occurs in your string many times. (This will also happen with basic, dot, word, act, work, etc.) To fix this, you must match on entire words. Add a comma at the beginning and end of the test string, and then search for words beginning and ending with a comma.

Also "l" is a really bad variable name because a(l) looks like a(1) in the VBA window.

Please Login or Register  to view this content.

Originally Posted by omahaNative_1023

can you give details on that? not sure i understand. why does adding comma at beginning and end help?

If a word in the subject is "a" instead of matching on "a" you need to match on ",a," to make sure that it matches an entire keyword, not just part of a keyword. So first I recommended adding a comma at the beginning and end of the word you are searching for to guarantee an exact match. If you do that, then you need a comma at the beginning and the end of the list of keywords to be able to match ",php," and ",embedded,".

i was talking about public consts.

You were responding to my example and said, "reason i dont want to use constant and use function instead." You made no mention of global or public const.

i get 20-30 of these mails a day

No change you make to this code will make any noticeable difference in the time or memory efficiency of this code. It's an academic exercise with no practical benefit. I am the manager of a software development organization that builds systems where we worry about performance when we have 100,000 transactions per hour.