Improve Code

Honestly, there is no such thing as too clunky of a macro. If it works - and doesn't take all day - then don't worry about it.

Could it be improved? Probably. Is it worth improving? Probably not.

There are a number of problems with this code, and opportunities for improvement.

It appears that you did not show all your code, see blue text below.

You do not show any variable declarations. I strongly recommend to everyone that they use Option Explicit and declare variables. Doing so prevents a lot of bugs and runtime errors.

You assign strings to the PerfDaten and Now2 variables, but want to use them as dates. Just make them dates. And use the built-in function Date to give the current date rather than using Now() and then manipulating it to give just the date.

It is not necessary to use ThisWorkbook to qualify range references. This is the default.

Your code for each day is identical except for the day and sheets. This can be factored out, greatly improving maintainability.

Do not Select sheets or other objects to manipulate them. Just reference them directly. There are exceptions to this but they don't apply to your code.

You do not need to unhide then hide these sheets to do any of this work, once you eliminate Select and Selection.

Variable MyFile is undefined, used in Workbooks(MyFile). I have no idea what you are trying to refer to here.

In the merging part you are doing a PasteValues and then a PasteFormats. This is essentially just a Paste, not sure why you are doing it this way.

Here is the rewritten code, but I cannot test it without having your file. If you attach a file with sample data I'd be happy to test it.

Please Login or Register  to view this content.