Issues converting VBA to VBS - Using ShellAndWait with APIs

**wherbjr35** · 05-08-2014, 10:09 AM

Hello scripters, I'm having some issues converting some VBA code to run in VB script format and i could use some help please.

I have the following VBA code that runs in a module and works perfectly. The code loops a WSH shell call to a executable, then waits for the exe to complete before moving to the next iteration. I don't necessarily need this code to be modified. I am running into issues trying to get code ported to run in VBS format. I've been doing some research on various components of VBA that dont exist in VBS, but i dont that applies here. Thanks for looking. The first three snippets all run from a VBA module, and the in progress stuff is just that. I basically copied the VBA to a new file and started to strip out and reformat syntax, to the best of my ability. I'm also assuming i'll need/use the APIs in the same way as before...this is foggy to me

Please Login or Register  to view this content.

Please Login or Register  to view this content.

Please Login or Register  to view this content.

########The VBS starts here########

Please Login or Register  to view this content.

Please Login or Register  to view this content.

**wherbjr35** · 05-09-2014, 10:56 AM

I had to do away with the API calls, so now two VBA routines becomes one VBS. Using .Run, I now can at least execute a shell call to my prog and wait. Can someone confirm, setting bWaitOnReturn will prevent a subsequent shell call from occurring until the previous finishes? That is how I understand it to work, but I still get an occassional crash. I'm looking into anything that would ensure smooth and graceful termination of the main program between loop iterations. Sub RunProgs is called numerous times by another routine.

Please Login or Register  to view this content.

**Leith Ross** · 05-09-2014, 11:38 AM

Hello wherbjr35,

Setting the argument bWaitOnReturn to True will halt the script execution until the program finishes, and Run returns any error code returned by the program. This only applies to the code you have called. If the VBS is being called by others then each module runs independently. You should check the return value from the run method before proceeding in your loop. If a program has failed to execute then you probably should alert the user and stop the procedure until the error has been corrected. Continuing on may be the cause of the crash.