Code to paste values from different workbook

Hello.
I've been doing quite a bit of searching for the following issue but i cannot seem to figure out the issue.
Normally when a code copies a cell value from Workbook-A, closes Workbook-A and then pastes the value into Workbook-B it works flawlessly. However, i noticed that this doesn't work in all case, for example when a code repeats itself with the "For - Next" function then when the code copies from one workbook to the other it causes an error.
here is my code and i made the part of the code that is red is where the issue lies.

Please Login or Register  to view this content.

First things first, you should indent loops, ifs, and withs so that you can read your code better. Like this

Please Login or Register  to view this content.

Second, I'm glad you have been working hard at figuring this out. We could use more of that around here. At the end of the day, what's important isn't that you get one task over with, but that you develop a skill and learn for the future. That said, it would probably be both easier for us and more educational for you, if you posted a sample workbook(s), with an example of the result you wanted, and then let one of us come up with a solution. My first question on here, I asked for help with code, someone insisted I post a sample workbook, and then they came back with code that looked alien to me, but worked wonderfully. It took me a while to walk through their code, google pieces, try running pieces, and figure out how they did it, but I'm really glad that I had that example, because I code much better for it.

Oh, okay. I see where you're hitting the error. Can you explain what the eventual goal is? This is doing something for a single row. Are you not going to use the other rows? Are you going to have a new workbook created for each row? There are a couple ways to fix your error, but what's best depends on what your ultimate goal is.

I'm curious. Can you tell me why you want to do that?

Sent from my SPH-D710 using Tapatalk

Ok that makes sense. And I'm guessing you want the invoices to be excel files, not pdfs? Have a good sabbath

Sent from my SPH-D710 using Tapatalk

Here kosherboy, try this code. You'll have to change the file path.

Please Login or Register  to view this content.

Yeah, maybe I'm confused about what you want. I thought you wanted to make one invoice for each PO No. with all the items for that PO No. Are you saying you want a separate spreadsheet for every item for every PO No? Or do you only want it to work for one PO No?

You are welcome. Glad you could make it work! BTW, conventional coding wisdom says to avoid using ActiveCell and Select. They are okay for small operations, but there are too many ways that things can go wrong with them. Most of the time, instead of using ActiveCell, you can use a variable to track where you are, so that the user clicking somewhere won't mess things up. You can also avoid most .Select statements, and make your code more efficient by elimintating the trip to the clipboard and back when copying. For example, you can make this section of the code cleaner and faster.

Please Login or Register  to view this content.

by writing it like this:

Please Login or Register  to view this content.

Or this code

Please Login or Register  to view this content.

Can be written as this

Please Login or Register  to view this content.

Glad that things worked out for you. Let me know if you want any more help