Is there a way to shorten a code similar to the below? (i know it's not a complete code - it's an example) It just keeps going until they're all TRUE and then ends with an Else which has them all set to FALSE.
ValueX is determined elsewhere
Values A,B,C etc will be in increments of 1
I'm new to code (learning as I go) so if you could explain the different parts of your code it would be very helpful.
Please Login or Register to view this content.
Last edited by DHFE; 11-05-2015 at 08:24 AM.
Hi DHFE,
The only thing I would suggest with the existing code, is a different method of indenting. There may be ways to shorten the code, but as written, the code is very easy to read and to maintain.
I would write the code as:
LewisPlease Login or Register to view this content.
As i stated, this is an example - it's not what the final code looks like. I'm looking for something that will take ValueX compare it against Values A,B,C etc and set the Frames.Visible to True or False accordingly without me having to write 80+ lines of code just to get what i want - especially since i have to enter similar versions of this code into 5 or 6 separate UserForms.
Last edited by DHFE; 11-05-2015 at 09:07 AM.
Hi,
Please upload the workbook so that we can see in context.
How many Frames are there? Your brief explanation suggests that there are as many Frames as there are Values A,B,C etc. since that's implied by your statement that "It just keeps going until they're all TRUE", although there is some doubt since you then say "and then ends with an Else which has them all set to FALSE." which might suggest there are fewer Frames than there are A.B,C etc..
Richard Buttrey
RIP - d. 06/10/2022
If any of the responses have helped then please consider rating them by clicking the small star iconbelow the post.
At the moment there's 10 frames and values 'A,B,C' are 1, 2, 3, 4 & 5 and two frames change from False to True with each increment of the value
The following was done in an ordinary code module. Remove the "UserForm1." if done in the UserForm module:
Please Login or Register to view this content.
as i stated in my original post, i'm new to code so could you explain what's happening and where? At the moment I'm getting a type mismatch error
edit:
Never mind i got it to work using the following;
Please Login or Register to view this content.
Last edited by DHFE; 11-11-2015 at 07:02 AM.
Hi,
Thank you very much for the rep points. I'm glad you got it working.
For future reference:
'Option Explicit' is a MUST.
It is a best practice to declare all variables. If you misspell a variable in your code, VBA will silently assume it is a Variant variable and go on executing with no clue to you that you have a bug. Go to the VBA development window, click Tools, Options, and check "Require Variable Declaration." This will insert the following line at the top of all new modules:
This option requires all variables to be declared and will give a compiler error for undeclared variables.Please Login or Register to view this content.
Debugger Secrets:
a. Press 'F8' to single step (goes into subroutines and functions).
b. Press SHIFT 'F8' to single step OVER subroutines and functions.
c. Press CTRL 'F8' to stop at the line where the cursor is.
d. 'Left Click' the margin to the left of a line to set (or clear) a BREAKPOINT.
e. Press CTRL 'G' to open the IMMEDIATE WINDOW. 'debug.print' statements send their
output to the IMMEDIATE WINDOW.
f. Select View > Locals to see all variables while debugging.
g. To automatically set a BREAKPOINT at a certain location put in the line:
'Debug.Assert False'
h. To conditionally set a BREAKPOINT at a certain location put in lines similar to:
if i >= 20 and xTV20 > 99.56 then
Debug.Assert False
endif
i. A variable value will be displayed by putting the cursor over the variable name.
Lewis
There are currently 1 users browsing this thread. (0 members and 1 guests)
Posting Permissions
LinkBack URL
About LinkBacks
Register To Reply
Bookmarks