Amend macro in excel

Hi Arkadi,

Thanks very much for your solution. It helped a lot. However, I am now getting a different error - Loop without Do

on the below code-

If UCase(WBin.Worksheets(1).Range("O" & inRow).Value) = "N" Then 'V07 21/02/2017
If .Range("G" & inRow) = 0 Then
If .Range("E" & inRow) = 20 Then '
lngWeight = (WBin.Worksheets(1).Range("L" & inRow) + 2000) '
ElseIf .Range("E" & inRow) = 40 Then '
lngWeight = (WBin.Worksheets(1).Range("L" & inRow) + 4000) '
ElseIf .Range("E" & inRow) = 45 Then '
lngWeight = (WBin.Worksheets(1).Range("L" & inRow) + 4000)
Else '
lngWeight = 0 '
End If '
Else '
lngWeight = WBin.Worksheets(1).Range("G" & inRow)
End If


If UCase(WBin.Worksheets(1).Range("O" & inRow).Value) = "Y" Then 'V07 21/02/2017
If .Range("G" & inRow) = 0 Then
If .Range("E" & inRow) = 20 Then '
lngWeight = (WBin.Worksheets(1).Range("N" & inRow)) '
ElseIf .Range("E" & inRow) = 40 Then '
lngWeight = (WBin.Worksheets(1).Range("N" & inRow)) '
ElseIf .Range("E" & inRow) = 45 Then '
lngWeight = (WBin.Worksheets(1).Range("N" & inRow))
Else '
lngWeight = 0 '
End If '
Else '
lngWeight = WBin.Worksheets(1).Range("N" & inRow)
End If




If .Range("F" & inRow) = 96 Then
If .Range("E" & inRow) = 40 Then
CBF.POD(i).intWeight(3) = CBF.POD(i).intWeight(3) + lngWeight 'POD TotalWeight (E) 'V07 13/01/2004
ElseIf .Range("E" & inRow) = 45 Then
CBF.POD(i).intWeight(4) = CBF.POD(i).intWeight(4) + lngWeight 'POD TotalWeight (E) 'V07.25 27/08/2010
End If
ElseIf .Range("E" & inRow) = 20 Then
CBF.POD(i).intWeight(1) = CBF.POD(i).intWeight(1) + lngWeight 'POD TotalWeight (C) 'V07
ElseIf .Range("E" & inRow) = 40 Then
CBF.POD(i).intWeight(2) = CBF.POD(i).intWeight(2) + lngWeight 'POD TotalWeight (D) 'V07
End If

inRow = inRow + 1
Loop
End With

Originally Posted by Arkadi

Hi lashiv,

Two things....

Please Login or Register  to view this content.

are you sure it will never be a capital N instead of lowercase n? I assume it is a letter in the cell....

n by itself is 0 (but also not accepted since it is not a declared variable) since without quotes VBA will think it is a variable. So to fix your code:

Please Login or Register  to view this content.

But if the cell could have n or N then:

Please Login or Register  to view this content.

That one will check if the uppercase value of the cell is "N" so both n and N will be a match.

Same solution for Y, you need quotes around it.

I would also ask that you check the forum rules, especially rule # 3 about code tags? Thanks.

A blindingly obvious error - You have a LOOP statement without a corresponding DO statement. They always come in pairs.

You could, perhaps, remove the LOOP statement but without knowing the logic, or other code you may not have posted, it's possible you need to add a DO statement.

You have already been asked to correct the code tags...

I would also ask that you check the forum rules, especially rule # 3 about code tags? Thanks.

Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code.

Posting code between [CODE]Please [url=https://www.excelforum.com/login.php]Login or Register [/url] to view this content.[/CODE] tags makes your code much easier to read and copy for testing, it also maintains VBA formatting.

Click on Edit to open your thread, then highlight your code and click the # icon at the top of your post window. More information about these and other tags can be found here

(This thread should receive no further responses until this moderation request is fulfilled, as per Forum Rule 7)

Thanks a lot for your help.

The Loop error has been rectified now, however, I get this error (screenshot attached) while compiling the code - Compile error in hidden module. The error commonly occurs when the code is incompatible with the version, platform or architecture of the application.

Thanks.