Opening .Xls Attachement from Email based on Subject/Sender

Forgot to mention, if you have more than one email account configured in Outlook, you'll have to change this line accordingly:

Please Login or Register  to view this content.

Tim

Sorry, original post deleted as it contained sensitive info... Try this?

Please Login or Register  to view this content.

Tim

Just an observation... It's not necessary to include "on error resume next", and it's really bad practice. The code above works without it.

Hmmm. That's strange. Wonder if it's a different version of Outlook, or Windoze or something.

It's not a good idea to use "on error resume next", unless you anticipate a potential error and take steps to mitigate it. It can sometimes mask unforeseen errors, and you end up sitting there scratching your head wondering what's going on. I do sometimes use it if I don't know whether an object is going to exist, so I do something like

Please Login or Register  to view this content.

Here you could adopt a similar approach with

Please Login or Register  to view this content.

Notice how I've included "on error goto exitsub" twice - once in case the IF...THEN returns true, and the other in case not. The principle is you're minimising the amount of code that runs without error checking to avoid that unanticipated error that will otherwise be puzzling.

Tim

Interesting thank a lot Tim appreciate it this has been great help I wanted to thank you.

I've been using this code the last week and its great, i am trying to do one adaptation to it now. Some emails cause a break, something to do with the senders address as it breaks here. "Debug.Print Targetemail.SenderEmailAddress"

How can I error handlethat if this happens don't exit sub but go to next i. I think the error handle im adding is not working

Also, another thing im trying to do is if it does not find my target Email Subject from Target Sender on Date = today, then to check Date -1 instead.... and loop -1 until it finds the email

Please Login or Register  to view this content.

If you knew how to do this quickly would appreciate it, ive been trying too.

Hi there. Sorry, been away for a few days. I wouldn't search "until a match is found" - otherwise you will end up with an infinite loop if there actually is not match.

You could achieve recursing back a specified number of days by wrapping the actual search in another loop like this:

Please Login or Register  to view this content.

So the full code would be:

Please Login or Register  to view this content.

Tim

Thank you so much. The probllem I am having now is that in the loop "For i = objFolder.Items.Count To 1 Step -1"

objFolder.Items.Count is counting all my emails in the Inbox going back all the way to December so thousands of items, i = +10,000, where as I need it to count only the emails from today. So as it is now the Loop goes through all the i values, counting other days too, without Next DateToFind being triggered, so we never get a match.

Im trying to restrict the Items.Count to count only Today's email.

Also, I have some Undeliverable emails in the inbox, since these aren't Outllok "Mail Items", they are Outllok "Report Items" it is causing the code to break despite my error handles. Sorry I know I'm a pain

Might I suggest you get a grip on your inbox! 10,000 items!?!

Seriously, though, the trouble is that, although new emails end up at the "top" of the email list, they aren't stored in strict date order (at least on my machine they aren't), so it's not as simple as quitting the loop once a certain date (e.g. today minus x-days) has been reached.

One way around it would be to set up a filter in Outlook so your target emails end up in one folder and run the search on that. That would also fix the "Report Items" issue which don't have the elements you're looking for.

In this bit of code Folders(1) is the mailbox (assuming you have only one account configured it'll be "1"). The Folders("Inbox") is then self explanatory.

Please Login or Register  to view this content.

So... if you create a Trade Notifications folder it would read

Please Login or Register  to view this content.

Or as a subfolder of the Inbox:

Please Login or Register  to view this content.

This would speed things up dramatically and you'd have the added benefit of an organised Inbox.

Also, try changing targetemail.SentOn to targetemail.ReceivedTime... Report items might not have a "SentOn" time, but if the do have a "ReceivedTime" it might fix that issue. It's only a guess, because I don't have any reports to look at.

Please Login or Register  to view this content.

I'm not overly familiar with Outlook, so I'm not very sure on this one.


Tim

Well, sometimes it just takes a different pair of eyes to look at a problem - it's easy to get bogged down going down one rabbit hole when there are plenty of others to choose from.

Glad you got there in the end!

Tim