Run-time error -2147417848 (80010108) Method "Show" of object failed

Someone else just had the same problem. Which is very unusual because DialogSheets are obsolete.

Once I fixed your declarations so I could run this on a 64-bit system, it worked for me. Is this what is supposed to happen at that point?
dialog.jpg

The member above had to reinstall Office to fix it, but I'm not sure that's the only solution.

Oh wow, maybe this was due to an office update then. Yes that is what was supposed to happen. Thats great you figured it out. What did you have to change to fix it?

Thank you so much!

You should create a new type of "dialog boxes" i.e. "UserForms".
The changes in the code will not be drastic, e.g.:

Please Login or Register  to view this content.

, although the "workload" may turn out to be quite large, because you have to create all "dialogs" with edit fields from scratch.

Originally Posted by brockbaker27

Thats great you figured it out. What did you have to change to fix it?

I didn't fix it. I just tried running it and it ran.

My version of Office is 64-bit. You have library calls that are 32-bit so I had to change them just to be able to compile the code. The quick explanation is that a function has to be declared as

Please Login or Register  to view this content.

and any Long variables for that function have to be declared LongPtr. If the function returns a LongPtr, then any variable you assign it to has to be declared LongPtr.

But that isn't the problem. That just happens to be what I had to do to try your code; your code doesn't compile on a 64-bit system.

The other case I looked at did not have 32-bit library calls, so I just opened it and it ran.

Since you both had the same problem at the same time, I do suspect an Office update. However, that doesn't explain why it runs for me.

I am having the same problem today. Excel updated itself a couple of hours ago and I can't make it go back to the old version.
My code is incredibly simple and has been running for 20 years I think

DialogSheets("PostingList").Show

That's all - and I get Method 'show' of object 'DialogSheet' failed - and then I can't even save the workbook but have to go to transaction manager and end the application!

Welcome to the Forum AdrianStern!

Although it appears that you have a similar problem, we prefer that you open a new thread rather than adding your question to an existing thread. You can monitor this thread for answers to the original question, which may solve yours, or you can start a new thread with the details of your own problem. (Once you post to a thread you are automatically subscribed, and depending on your settings you will get emails when there are new posts. You can login and go to User CP to see your subscribed threads.)

As a new member, please take the time to review our rules. There aren't many, and they are all important. Here is the applicable rule:

Please see Forum Rule #4 about hijacking and start a new thread for your query.

If you are not familiar with how to start a new thread see the FAQ: How to start a new thread

I wasn't asking a question. Just adding a comment that this happened to me today
It seems that suddenly DialogSheets are no longer supported from this new version of excel with no warning
It looks as though I have to replace it with a UserForm which I have started on. I suppose like in old VB.
Damn nuisance.
MS are a damn nuisance - always were too big for their boots. Like the mystery of what Outlook is up to all the time when it should be doing nothing at all it can draw
over 65% cpu. Not a bug they say. My cpu is too small they say. Previous versions worked normally
Ah well. Have to sit and code and debug for a few hours

Hello porucha vevrku,

I am not very good at updating old programs with userforms. I am getting an error at the .Edit_PN.Text = default. Could you see what I am doing wrong?

Please Login or Register  to view this content.

I checked my version and there were updates pending. When I applied the updates, now when I run the same code that worked before, Excel crashes on Show for DialogSheets. The process dies.

So there is some issue introduced in the latest update. I can't speculate as to whether it was deliberate deprecation of DialogSheets or simply a new bug.

Originally Posted by brockbaker27

...I am getting an error at the .Edit_PN.Text = default. Could you see what I am doing wrong? ...

You must first create a "UserForm" with its objects (text boxes, lists, buttons, etc.) and adapt the code to the names you give these objects in "UserForm".

Originally Posted by rorya

This is not correct. Only pointers/handles should be declared as LongPtr, not all Long variables. That is likely to get you into trouble with API calls!

I stand corrected. I was shooting from the hip, should have confirmed this before posting.

Originally Posted by porucha vevrku

You must first create a "UserForm" with its objects (text boxes, lists, buttons, etc.) and adapt the code to the names you give these objects in "UserForm".

To expand on this, it appears that brockbaker27 simply declared a UserForm object, but the way to do this is to create a UserForm in the VBA design window, to reproduce the original DialogSheet. A declaration for the UserForm is not needed, just use the name of the UserForm in the code.

The Show method for a UserForm does not return a value. You are treating it as a Boolean function. You will have to redesign this aspect to have the form indicate whether something was entered. I assume that is if the user hit OK instead of Cancel. You can add a public variable in the UserForm code to indicate it. I usually do something like this:

Please Login or Register  to view this content.

Then

Please Login or Register  to view this content.

I have posted in the Microsoft Community and it seems that this is a widespread issue due to the update. I have not been able to determine if it was deliberate.