code is not giving the expected result

[RAJESH SHAH]

Hello Experts
This code will extract the data of combined data sheet and display in the newly created sheet (HSN). The code has to extract data based on unique values of 3 columns. B J and R). When I filter the data of both the sheets the code has to match the amounts of each state code and each HSN code individually. But I am getting a mismatch in one of the HSN codes due to which the final result is incorrect. I need your expertise to check what is wrong in the code and help me to correct it. Thanks in advance.

[veyselemre]

Please Login or Register  to view this content.

[RAJESH SHAH]

veyselemre. Can you please tell which part of the code did you edit.? Last 3 days I have been trying to figure out why the difference. I would like to know what was wrong in the code.

[RAJESH SHAH]

Thank you very much veyselemre. It worked in the original data too. Phew!! Thank God the problem is solved.
I compared the codes and found that you have replaced str with key which might have made the difference. Anyways thanks once again.

[veyselemre]

Hello, I don't know english. I wrote it with a translator.
1-Key is written instead of str variable. str is already a vb command. It does not give an error, but it is not recommended to use it.
2-For the keys that are not found in the Dictionary, an index was created by saying x=x+1, but this index was not thrown into the dictionary.
3-The index of the ones in the Dictionary was taken into the y variable and collected over the old values.
Ekran Alıntısı.PNG

[RAJESH SHAH]

What is the reason it is not recommended.? It gave the perfect results in all the state codes. Believe it or not, I was going mad to find the fault and finally after 3 days of head breaking I thought the code needs to be edited where and how I wasn't aware. But this helped me to complete my project successfully. You hit the last nail in the coffin.
If it is not recommended will it give me any problems in future ...???

[TMS]

It is bad practice to use Excel and/or VBA key words as variables, function names, or subroutine names. It can, and does, produce unexpected results, if not errors

[RAJESH SHAH]

Then is it possible to edit the present code and get the correct result without the key.... I have tried and posted multiple queries but I haven't got the correct expected result till now. If possible help me to edit the code without the key and get the expected result.
Thanks for the update Trevor. Hope some expert will be able to edit the code without the key. Till then I will check different data to check if it is giving the result differently or incorrect.
Even veyselemre warned in his post in the first line itself that it is not recommended to use key.

[TMS]

I should have said "Reserved words" rather than key words.

For example, if I want to use a long variable to refer to a row number, I will use lRow rather than Row.

So

Please Login or Register  to view this content.

[Marc L]

help me to correct it.

Already solved in your previous thread where I gave you a faster way !

TotalAP.jpg